Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755537AbcCCUeI (ORCPT ); Thu, 3 Mar 2016 15:34:08 -0500 Received: from mail-lb0-f178.google.com ([209.85.217.178]:35681 "EHLO mail-lb0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751207AbcCCUeG (ORCPT ); Thu, 3 Mar 2016 15:34:06 -0500 MIME-Version: 1.0 In-Reply-To: References: <1456874438-26330-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com> <7h60x3wbrc.fsf@baylibre.com> Date: Thu, 3 Mar 2016 21:34:04 +0100 X-Google-Sender-Auth: haXF25QSo9_3-z952nE9pHZERTw Message-ID: Subject: Re: [PATCH] PM / Domains: Propagate start and restore errors during runtime resume From: "Rafael J. Wysocki" To: "Rafael J. Wysocki" Cc: Kevin Hilman , Laurent Pinchart , "linux-pm@vger.kernel.org" , Linux Kernel Mailing List , "Rafael J. Wysocki" , Ulf Hansson Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1659 Lines: 35 On Thu, Mar 3, 2016 at 9:32 PM, Rafael J. Wysocki wrote: > On Thu, Mar 3, 2016 at 9:24 PM, Kevin Hilman wrote: >> Laurent Pinchart writes: >> >>> During runtime resume the return values of the start and restore steps >>> are ignored. As a result drivers are not notified of runtime resume >>> failures and can't propagate them up. Fix it by returning an error if >>> either the start or restore step fails, and clean up properly in the >>> error path. >>> >>> Signed-off-by: Laurent Pinchart >>> --- >>> drivers/base/power/domain.c | 20 ++++++++++++++++++-- >>> 1 file changed, 18 insertions(+), 2 deletions(-) >>> >>> This fixes an issue I've noticed with my driver's .runtime_resume() handler >>> returning an error that was never propagated out of pm_runtime_get_sync(). >> >> Acked-by: Kevin Hilman >> >>> A second issue then appeared. The device .runtime_error field is set to the >>> error code returned by my .runtime_resume() handler, but it never reset. Any >>> subsequent try to resume the device fails with -EINVAL. I'm not sure what the >>> right way to solve that is, advices are welcome. >> >> Probably setting it (back) to zero after each successful runtime_suspend >> or runtime_resume is the right way. Rafael? > > That follows the assumption that runtime PM usually won't be reliable > after an error, so runtime_error has to be cleared explicitly via > pm_runtime_set_status(). Sorry, that won't work. Anyway, the idea is that the error has to be cleared manually after a failure.