Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756369AbcCCUya (ORCPT <rfc822;w@1wt.eu>);
	Thu, 3 Mar 2016 15:54:30 -0500
Received: from mail-yw0-f178.google.com ([209.85.161.178]:34475 "EHLO
	mail-yw0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754918AbcCCUy3 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 3 Mar 2016 15:54:29 -0500
MIME-Version: 1.0
In-Reply-To: <20160303161714.GA4133@kroah.com>
References: <1456955489-18971-1-git-send-email-gustavo@padovan.org>
	<1457015837-7609-1-git-send-email-gustavo@padovan.org>
	<20160303161714.GA4133@kroah.com>
Date: Thu, 3 Mar 2016 15:54:27 -0500
Message-ID: <CAF6AEGtGxuvfYYvHLG6bvnoAxbdw=Vrai5X2ObiUiLF9wgC4Fg@mail.gmail.com>
Subject: Re: [PATCH] staging/android: add flags member to sync ioctl structs
From: Rob Clark <robdclark@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Gustavo Padovan <gustavo@padovan.org>, devel@driverdev.osuosl.org,
        Daniel Stone <daniels@collabora.com>,
        Daniel Vetter <daniel.vetter@ffwll.ch>,
        Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Riley Andrews <riandrews@android.com>,
        "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        =?UTF-8?B?QXJ2ZSBIasO4bm5ldsOlZw==?= <arve@android.com>,
        Greg Hackmann <ghackmann@google.com>,
        Gustavo Padovan <gustavo.padovan@collabora.co.uk>,
        John Harrison <John.C.Harrison@intel.com>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1169
Lines: 34

On Thu, Mar 3, 2016 at 11:17 AM, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
> On Thu, Mar 03, 2016 at 11:37:17AM -0300, Gustavo Padovan wrote:
>> From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
>>
>> Play safe and add flags member to all structs. So we don't need to
>> break API or create new IOCTL in the future if new features that requires
>> flags arises.
>>
>> v2: check if flags are valid (zero, in this case)
>>
>> v3: return -EINVAL if flags are not zero'ed
>>
>> v4: add padding for 64-bit alignment
>>
>> v5: rebase to use only stacked sync_file_info
>
> Why are these vX things here in the changelog?
>
> And you just broke all existing userspace users of this code, why are
> you allowed to do that?
>
> not ok...

There are not really any users of this on an upstream kernel yet, so
it makes sense to fix the ABI to something we can live with now,
before that changes.  If we are stuck not breaking ABI with android
stuff pulled into staging as we destage it, then maybe we should be a
*lot* slower at pulling android stuff into staging.  (Ie. if that is
the case, please kick it all out now and we'll re-add things
properly.)

BR,
-R