Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757714AbcCCU55 (ORCPT ); Thu, 3 Mar 2016 15:57:57 -0500 Received: from mail-io0-f174.google.com ([209.85.223.174]:35606 "EHLO mail-io0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754890AbcCCU54 (ORCPT ); Thu, 3 Mar 2016 15:57:56 -0500 MIME-Version: 1.0 In-Reply-To: <20160303172516.GA24567@kernel.dk> References: <20160303172516.GA24567@kernel.dk> Date: Thu, 3 Mar 2016 12:57:55 -0800 X-Google-Sender-Auth: VJdTi5mqpfVGW9Wvw-khZFKAtOg Message-ID: Subject: Re: [GIT PULL] Block fixes for 4.5-final From: Linus Torvalds To: Jens Axboe Cc: Linux Kernel Mailing List , linux-block@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2244 Lines: 57 On Thu, Mar 3, 2016 at 9:25 AM, Jens Axboe wrote: => > A set of fixes for 4.5-rc6 - it's a lot bigger than I would like at this > point, but there's really nothing in here that we should not merge for > 4.5 final - with a possible exception [..] With the possible exception of pretty much everything. NONE of this seems really to be appropriate for this stage. It doesn't fix regressions, it doesn't fix security stuff, it doesn't really fix major oopses. Why did you send it to me? Right now, the block layer has been the problem child for several releases. This has got to stop. Example of a couple of commits that made me decide to actually unpull this already after I had pulled it: - commit 35b3ccc7d71c (from yesterday) changed old code that checked for REQ_TYPE_BLOCK_PC to check for a bigger range - then, today, commit 5b16f4f2b5e9 then changes that same code to instead just check for REQ_TYPE_FS Before this cluster-fuck of a pull request, that code had apparently worked well enough that it hadn't been touched since 2012. So the "bug" it fixed clearly was clearly not hugely critical. The fix itself was clearly not discussed or thought out, since it ended up changing. It wasn't even important enough to mark for stable, although the code has clearly been that way for almost three years now. And Gods, that was just the most obvious "this pull request is pure shit". The rest of the pull request really in no way looked critical enough to be rc6+ material. Seriously. So why the f*ck does the block layer end up being this kind of a problem? Really. You need to get a grip, and start thinking about your pull requests a *lot* more.m None of this "let's send Linus random crap at any time in the release process". I pulled it and then spent half an hour thinking about it, and decided that there's no way in hell pulling this is the right thing, so I had to not just unpull it, but undo and then re-do another pull I had done in the meantime. Get your act together, Jens. You knew this was big and late. And absolutely *none* of it looked critical to me. Feel free to resend the parts that are actually critical, but explain exactly why they are so critical when you do. Linus