Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932864AbcCCWyH (ORCPT ); Thu, 3 Mar 2016 17:54:07 -0500 Received: from mail.kernel.org ([198.145.29.136]:42960 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932234AbcCCWyE (ORCPT ); Thu, 3 Mar 2016 17:54:04 -0500 Date: Thu, 3 Mar 2016 16:53:59 -0600 From: Rob Herring To: "David Rivshin (Allworx)" Cc: "devicetree@vger.kernel.org" , Frank Rowand , Grant Likely , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] of: add 'const' for of_property_*_string*() parameter '*np' Message-ID: <20160303225359.GC17541@rob-hp-laptop> References: <1456954551-31742-1-git-send-email-drivshin.allworx@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1138 Lines: 29 On Thu, Mar 03, 2016 at 07:52:51AM -0600, Rob Herring wrote: > On Wed, Mar 2, 2016 at 3:35 PM, David Rivshin (Allworx) > wrote: > > From: David Rivshin > > > > The of_property_{read,count,match}_string* family of functions never > > modify the struct device_node pointer that is passed in, so there is no > > reason for it to be non-const. Equivalent functions for all other types > > already take a 'const struct device_node *np'. > > > > Signed-off-by: David Rivshin > > --- > > > > MAINTAINTERS says that the appropriate tree is > > git://git.kernel.org/pub/scm/linux/kernel/git/glikely/linux.git > > Yes, we probably need to update that. > > > but it looks like that hasn't been updated in a while. So this patch > > is based off the "for-next" branch of > > git://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git > > instead. Let me know if you need me to respin from another tree/branch. > > You should base off of Linus' tree unless you have some dependency. I > doubt it matters in this case, so no need to resend. And now applied. Rob