Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932853AbcCCXHR (ORCPT ); Thu, 3 Mar 2016 18:07:17 -0500 Received: from TYO201.gate.nec.co.jp ([210.143.35.51]:33193 "EHLO tyo201.gate.nec.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932234AbcCCXHP convert rfc822-to-8bit (ORCPT ); Thu, 3 Mar 2016 18:07:15 -0500 From: Naoya Horiguchi To: Jan Stancek CC: "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , "akpm@linux-foundation.org" , "mike.kravetz@oracle.com" , "hillf.zj@alibaba-inc.com" , "kirill.shutemov@linux.intel.com" , "dave.hansen@linux.intel.com" , "paul.gortmaker@windriver.com" Subject: Re: [PATCH] mm/hugetlb: use EOPNOTSUPP in hugetlb sysctl handlers Thread-Topic: [PATCH] mm/hugetlb: use EOPNOTSUPP in hugetlb sysctl handlers Thread-Index: AQHRdTPo4zAvLpekJ0+A9O56nHj0J59HwTQA Date: Thu, 3 Mar 2016 23:05:57 +0000 Message-ID: <20160303230556.GA9263@hori1.linux.bs1.fc.nec.co.jp> References: In-Reply-To: Accept-Language: ja-JP, en-US Content-Language: ja-JP X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.128.101.5] Content-Type: text/plain; charset="iso-2022-jp" Content-ID: <3A6AFC719D9D064B949D60A5B14CE109@gisp.nec.co.jp> Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1425 Lines: 46 On Thu, Mar 03, 2016 at 11:02:51AM +0100, Jan Stancek wrote: > Replace ENOTSUPP with EOPNOTSUPP. If hugepages are not supported, > this value is propagated to userspace. EOPNOTSUPP is part of uapi > and is widely supported by libc libraries. > > Cc: Andrew Morton > Cc: Naoya Horiguchi > Cc: Mike Kravetz > Cc: Hillf Danton > Cc: "Kirill A. Shutemov" > Cc: Dave Hansen > Cc: Paul Gortmaker > > Signed-off-by: Jan Stancek Acked-by: Naoya Horiguchi > --- > mm/hugetlb.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > index 01f2b48c8618..851a29928a99 100644 > --- a/mm/hugetlb.c > +++ b/mm/hugetlb.c > @@ -2751,7 +2751,7 @@ static int hugetlb_sysctl_handler_common(bool obey_mempolicy, > int ret; > > if (!hugepages_supported()) > - return -ENOTSUPP; > + return -EOPNOTSUPP; > > table->data = &tmp; > table->maxlen = sizeof(unsigned long); > @@ -2792,7 +2792,7 @@ int hugetlb_overcommit_handler(struct ctl_table *table, int write, > int ret; > > if (!hugepages_supported()) > - return -ENOTSUPP; > + return -EOPNOTSUPP; > > tmp = h->nr_overcommit_huge_pages; > > -- > 1.8.3.1 >