Message-ID: <56D8DF39.8020104@rock-chips.com>
Date: Fri, 04 Mar 2016 09:04:57 +0800
From: Mark yao <mark.yao@rock-chips.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0
MIME-Version: 1.0
To: John Keeping <john@metanate.com>
CC: Heiko Stuebner <heiko@sntech.de>, dri-devel@lists.freedesktop.org,
        linux-arm-kernel@lists.infradead.org,
        linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/rockchip: vop: fix crtc size in plane check
References: <1456143779-16208-1-git-send-email-john@metanate.com>
In-Reply-To: <1456143779-16208-1-git-send-email-john@metanate.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 459
Lines: 14

On 2016年02月22日 20:22, John Keeping wrote:
> If the geometry of a crtc is changing in an atomic update then we much

I think "we much validate" should be "we must validate".:-)

> validate the plane size against the new state of the crtc and not the
> current size, otherwise if the crtc size is increasing the plane will be
> cropped at the previous size and will not fill the screen.
>
> Signed-off-by: John Keeping<john@metanate.com>

-- 
Ｍark Yao