Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757230AbcCDGIv (ORCPT ); Fri, 4 Mar 2016 01:08:51 -0500 Received: from e28smtp06.in.ibm.com ([125.16.236.6]:38681 "EHLO e28smtp06.in.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753603AbcCDGIs (ORCPT ); Fri, 4 Mar 2016 01:08:48 -0500 X-IBM-Helo: d28relay04.in.ibm.com X-IBM-MailFrom: kamalesh@linux.vnet.ibm.com X-IBM-RcptTo: live-patching@vger.kernel.org;linux-kernel@vger.kernel.org Date: Fri, 4 Mar 2016 11:38:12 +0530 From: Kamalesh Babulal To: Petr Mladek Cc: linuxppc-dev@ozlabs.org, Balbir Singh , duwe@lst.de, linux-kernel@vger.kernel.org, rostedt@goodmis.org, jeyu@redhat.com, jkosina@suse.cz, live-patching@vger.kernel.org, mbenes@suse.cz, Torsten Duwe Subject: Re: [PATCH][v4] livepatch/ppc: Enable livepatching on powerpc Message-ID: <20160304060811.GA30681@linux.vnet.ibm.com> Reply-To: Kamalesh Babulal References: <1457023921-2051-1-git-send-email-pmladek@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <1457023921-2051-1-git-send-email-pmladek@suse.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-MML: disable x-cbid: 16030406-0021-0000-0000-00000A6F04CD Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1473 Lines: 44 * Petr Mladek [2016-03-03 17:52:01]: > From: Balbir Singh > > Changelog v4: > 1. Renamed klp_matchaddr() to klp_get_ftrace_location() > and used it just to convert the function address. > 2. Synced klp_write_module_reloc() with s390(); made it > inline, no error message, return -ENOSYS > 3. Added an error message when including > powerpc/include/asm/livepatch.h without HAVE_LIVEPATCH > 4. Update some comments. > Changelog v3: > 1. Moved -ENOSYS to -EINVAL in klp_write_module_reloc > 2. Moved klp_matchaddr to use ftrace_location_range > Changelog v2: > 1. Implement review comments by Michael > 2. The previous version compared _NIP from the > wrong location to check for whether we > are going to a patched location > > This applies on top of the patches posted by Michael > https://patchwork.ozlabs.org/patch/589791/ > > It enables livepatching. This takes patch 6/8 and 7/8 of v8 as the base. > (See the reference [1] below) and adds logic for checking offset ranges > in livepatch with ftrace_location_range. > > I tested the sample in the livepatch > > Signed-off-by: Torsten Duwe > Signed-off-by: Balbir Singh > Signed-off-by: Petr Mladek Reviewed-by: Kamalesh Babulal I tried it, with the sample livepatch module. Tested-by: Kamalesh Babulal Thanks, Kamalesh.