Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1759360AbcCDJQk (ORCPT <rfc822;w@1wt.eu>);
	Fri, 4 Mar 2016 04:16:40 -0500
Received: from mail-wm0-f67.google.com ([74.125.82.67]:36719 "EHLO
	mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1758006AbcCDJQc (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 4 Mar 2016 04:16:32 -0500
Date: Fri, 4 Mar 2016 10:16:28 +0100
From: Jiri Pirko <jiri@resnulli.us>
To: "Wei Hu(Xavier)" <xavier.huwei@huawei.com>
Cc: dledford@redhat.com, sean.hefty@intel.com, hal.rosenstock@gmail.com,
        davem@davemloft.net, jeffrey.t.kirsher@intel.com, jiri@mellanox.com,
        ogerlitz@mellanox.com, linux-rdma@vger.kernel.org,
        linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
        gongyangming@huawei.com, xiaokun@huawei.com, tangchaofei@huawei.com,
        oulijun@huawei.com, haifeng.wei@huawei.com, yisen.zhuang@huawei.com,
        yankejian@huawei.com, lisheng011@huawei.com,
        charles.chenxin@huawei.com, linuxarm@huawei.com
Subject: Re: [PATCH 3/4] infiniband: hns: add Hisilicon RoCE support(driver
 code)
Message-ID: <20160304091628.GB2150@nanopsycho.orion>
References: <1457080877-13456-1-git-send-email-xavier.huwei@huawei.com>
 <1457080877-13456-4-git-send-email-xavier.huwei@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1457080877-13456-4-git-send-email-xavier.huwei@huawei.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 803
Lines: 37

Fri, Mar 04, 2016 at 09:41:16AM CET, xavier.huwei@huawei.com wrote:

<snip>

>+int hns_roce_buf_alloc(
>+			struct hns_roce_dev *hr_dev,
>+			int size, int max_direct,
>+			struct hns_roce_buf *buf)

<snip>	
	
>+
>+			pages =
>+				kmalloc(sizeof(*pages) * buf->nbufs,
>+					GFP_KERNEL);

<snip>

>+
>+			buf->direct.buf = vmap(
>+						pages, buf->nbufs, VM_MAP,
>+						PAGE_KERNEL);

<snip>

>+	if (
>+		event_type != HNS_ROCE_EVENT_TYPE_CQ_ID_INVALID &&
>+		event_type != HNS_ROCE_EVENT_TYPE_CQ_ACCESS_ERROR &&
>+		event_type != HNS_ROCE_EVENT_TYPE_CQ_OVERFLOW) {
>+		dev_err(&hr_dev->pdev->dev,
>+			"hns_roce_ib: Unexpected event type 0x%x on CQ %06x\n",
>+			event_type, hr_cq->cqn);
>+		return;
>+	}

Although checkpatch does not complain, I find this semi-random adding of
newlines quite odd.