Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932364AbcCDJ1n (ORCPT ); Fri, 4 Mar 2016 04:27:43 -0500 Received: from mx2.suse.de ([195.135.220.15]:59793 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759032AbcCDJDa (ORCPT ); Fri, 4 Mar 2016 04:03:30 -0500 X-Amavis-Alert: BAD HEADER SECTION, Duplicate header field: "References" From: Jiri Slaby To: stable@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Anand Jain , David Sterba , Jiri Slaby Subject: [PATCH 3.12 074/116] Btrfs: add missing brelse when superblock checksum fails Date: Fri, 4 Mar 2016 10:01:59 +0100 Message-Id: <9ec709846fe9fe45a5d128a7e00f2aaa4e597a7f.1457082108.git.jslaby@suse.cz> X-Mailer: git-send-email 2.7.2 In-Reply-To: References: In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 962 Lines: 34 From: Anand Jain 3.12-stable review patch. If anyone has any objections, please let me know. =============== commit b2acdddfad13c38a1e8b927d83c3cf321f63601a upstream. Looks like oversight, call brelse() when checksum fails. Further down the code, in the non error path, we do call brelse() and so we don't see brelse() in the goto error paths. Signed-off-by: Anand Jain Reviewed-by: David Sterba Signed-off-by: David Sterba Signed-off-by: Jiri Slaby --- fs/btrfs/disk-io.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c index 3ec1cb0808c3..2622ec8a76f0 100644 --- a/fs/btrfs/disk-io.c +++ b/fs/btrfs/disk-io.c @@ -2340,6 +2340,7 @@ int open_ctree(struct super_block *sb, bh = btrfs_read_dev_super(fs_devices->latest_bdev); if (!bh) { err = -EINVAL; + brelse(bh); goto fail_alloc; } -- 2.7.2