Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759512AbcCDJc6 (ORCPT ); Fri, 4 Mar 2016 04:32:58 -0500 Received: from smtprelay01.ispgateway.de ([80.67.31.35]:38034 "EHLO smtprelay01.ispgateway.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759060AbcCDJcy (ORCPT ); Fri, 4 Mar 2016 04:32:54 -0500 X-Greylist: delayed 5106 seconds by postgrey-1.27 at vger.kernel.org; Fri, 04 Mar 2016 04:32:54 EST Subject: Re: [PATCH 1/5] usb: gadget: f_midi: refactor state machine To: Felipe Ferreri Tonello , linux-usb@vger.kernel.org References: <1456947640-20673-1-git-send-email-eu@felipetonello.com> <1456947640-20673-2-git-send-email-eu@felipetonello.com> <56D7567A.40402@ladisch.de> <56D7FC6B.7040709@felipetonello.com> <56D82237.2080705@ladisch.de> <56D866A1.5060303@felipetonello.com> Cc: linux-kernel@vger.kernel.org, Felipe Balbi , Michal Nazarewicz From: Clemens Ladisch Message-ID: <56D9424C.201@ladisch.de> Date: Fri, 4 Mar 2016 09:07:40 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <56D866A1.5060303@felipetonello.com> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Df-Sender: bGludXgtdXNiQGNsLmRvbWFpbmZhY3Rvcnkta3VuZGUuZGU= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 671 Lines: 19 Felipe Ferreri Tonello wrote: > On 03/03/16 11:38, Clemens Ladisch wrote: >> But in what way was the old state machine not "proper"? > > Because it didn't reflect all the correct and possible MIDI states The whole point of the one-byte real-time messages is that they do not affect the parsing of the surrounding MIDI stream. So not making them part of the state machine is the proper way of handling them. (Also see the flowchart in appendix A of the spec.) > This patch doesn't change any functionality. But the important thing > here is that it improves the driver maintainability [...] Then I won't get in the way of this driver's maintainer. Regards, Clemens