Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754647AbcCDNjY (ORCPT ); Fri, 4 Mar 2016 08:39:24 -0500 Received: from mail-lb0-f174.google.com ([209.85.217.174]:33748 "EHLO mail-lb0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751399AbcCDNjW (ORCPT ); Fri, 4 Mar 2016 08:39:22 -0500 Subject: Re: [PATCH net 4/6] net: hns: adds uc match for debug port To: Daode Huang , davem@davemloft.net References: <1457053798-93513-1-git-send-email-huangdaode@hisilicon.com> <1457053798-93513-5-git-send-email-huangdaode@hisilicon.com> Cc: liguozhu@hisilicon.com, Yisen.Zhuang@huawei.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, linuxarm@huawei.com, salil.mehta@huawei.com, kenneth-lee-2012@foxmail.com, xuwei5@hisilicon.com, lisheng011@huawei.com, yankejian@huawei.com From: Sergei Shtylyov Message-ID: <56D99007.6090804@cogentembedded.com> Date: Fri, 4 Mar 2016 16:39:19 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <1457053798-93513-5-git-send-email-huangdaode@hisilicon.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1457 Lines: 41 On 3/4/2016 4:09 AM, Daode Huang wrote: > This patch adds uc match for debug port by: > 1)Enables uc match of debug port when initializing gmac > 2)Enables uc match of mac address register2 > > Signed-off-by: Daode Huang > Signed-off-by: lipeng True/full name is required here. > --- > drivers/net/ethernet/hisilicon/hns/hns_dsaf_gmac.c | 18 +++++++++++++++++- > drivers/net/ethernet/hisilicon/hns/hns_dsaf_reg.h | 2 ++ > 2 files changed, 19 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_gmac.c b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_gmac.c > index b8517b0..2591a51 100644 > --- a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_gmac.c > +++ b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_gmac.c [...] > @@ -407,8 +419,12 @@ static void hns_gmac_set_mac_addr(void *mac_drv, char *mac_addr) > > u32 low_val = mac_addr[5] | (mac_addr[4] << 8) > | (mac_addr[3] << 16) | (mac_addr[2] << 24); > + > + u32 val = dsaf_read_dev(drv, GMAC_STATION_ADDR_HIGH_2_REG); > + u32 sta_addr_en = dsaf_get_bit(val, GMAC_ADDR_EN_B); Empty line needed after declarations. > dsaf_write_dev(drv, GMAC_STATION_ADDR_LOW_2_REG, low_val); > - dsaf_write_dev(drv, GMAC_STATION_ADDR_HIGH_2_REG, high_val); > + dsaf_write_dev(drv, GMAC_STATION_ADDR_HIGH_2_REG, > + high_val | (sta_addr_en << GMAC_ADDR_EN_B)); > } > } > [...] MBR, Sergei