Subject: Re: [PATCH] KVM: Remove redundant smp_mb() in the
 kvm_mmu_commit_zap_page()
To: Paolo Bonzini <pbonzini@redhat.com>, Lan Tianyu <tianyu.lan@intel.com>,
        gleb@kernel.org, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
        x86@kernel.org
References: <1457055312-27067-1-git-send-email-tianyu.lan@intel.com>
 <56D9417E.4000206@redhat.com>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org
From: Xiao Guangrong <guangrong.xiao@linux.intel.com>
Message-ID: <56D99226.8060208@linux.intel.com>
Date: Fri, 4 Mar 2016 21:48:22 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.5.1
MIME-Version: 1.0
In-Reply-To: <56D9417E.4000206@redhat.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1086
Lines: 38


On 03/04/2016 04:04 PM, Paolo Bonzini wrote:
> On 04/03/2016 02:35, Lan Tianyu wrote:
>> The following kvm_flush_remote_tlbs() will call smp_mb() inside and so
>> remove smp_mb() here.
>>
>> Signed-off-by: Lan Tianyu <tianyu.lan@intel.com>
>> ---
>>   arch/x86/kvm/mmu.c | 6 ------
>>   1 file changed, 6 deletions(-)
>>
>> diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c
>> index a54ecd9..6315416 100644
>> --- a/arch/x86/kvm/mmu.c
>> +++ b/arch/x86/kvm/mmu.c
>> @@ -2383,12 +2383,6 @@ static void kvm_mmu_commit_zap_page(struct kvm *kvm,
>>   		return;
>>
>>   	/*
>> -	 * wmb: make sure everyone sees our modifications to the page tables
>> -	 * rmb: make sure we see changes to vcpu->mode
>> -	 */
>> -	smp_mb();
>> -
>> -	/*
>>   	 * Wait for all vcpus to exit guest mode and/or lockless shadow
>>   	 * page table walks.
>>   	 */
>>
>
> kvm_flush_remote_tlbs loads kvm->tlbs_dirty before issuing the memory
> barrier.  I think it's okay if the load is done earlier, but I'd like
> Guangrong to take a look.

Yes, It looks good to me, but please keep the comment.

Thanks!