Subject: Re: [PATCH 2/4] infiniband: hns: add Hisilicon RoCE support(binding)
To: "Wei Hu(Xavier)" <xavier.huwei@huawei.com>, dledford@redhat.com,
        sean.hefty@intel.com, hal.rosenstock@gmail.com, davem@davemloft.net,
        jeffrey.t.kirsher@intel.com, jiri@mellanox.com, ogerlitz@mellanox.com
References: <1457080877-13456-1-git-send-email-xavier.huwei@huawei.com>
 <1457080877-13456-3-git-send-email-xavier.huwei@huawei.com>
Cc: linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
        netdev@vger.kernel.org, gongyangming@huawei.com, xiaokun@huawei.com,
        tangchaofei@huawei.com, oulijun@huawei.com, haifeng.wei@huawei.com,
        yisen.zhuang@huawei.com, yankejian@huawei.com, lisheng011@huawei.com,
        charles.chenxin@huawei.com, linuxarm@huawei.com
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Message-ID: <56D992E2.3060504@cogentembedded.com>
Date: Fri, 4 Mar 2016 16:51:30 +0300
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.6.0
MIME-Version: 1.0
In-Reply-To: <1457080877-13456-3-git-send-email-xavier.huwei@huawei.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1849
Lines: 52

Hello.

On 3/4/2016 11:41 AM, Wei Hu(Xavier) wrote:

> This submit add binding file and dts file.
>
> Signed-off-by: Wei Hu(Xavier) <xavier.huwei@huawei.com>
> Signed-off-by: oulijun <oulijun@huawei.com>
> ---
>   .../bindings/infiniband/hisilicon-hns-roce.txt     | 68 ++++++++++++++++++++++
>   1 file changed, 68 insertions(+)
>   create mode 100644 Documentation/devicetree/bindings/infiniband/hisilicon-hns-roce.txt
>
> diff --git a/Documentation/devicetree/bindings/infiniband/hisilicon-hns-roce.txt b/Documentation/devicetree/bindings/infiniband/hisilicon-hns-roce.txt
> new file mode 100644
> index 0000000..8004641
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/infiniband/hisilicon-hns-roce.txt
> @@ -0,0 +1,68 @@
> +HiSilicon RoCE DT description
> +
> +HiSilicon RoCE engine is a part of network subsystem.
> +It works depending on other part of network wubsytem, such as, gmac and
> +dsa fabric.
> +
> +Additional properties are described here:
> +
> +Required properties:
> +- compatible: Should contain "hisilicon,hns-roce-v1".
> +- reg: Physical base address of the roce driver and
> +length of memory mapped region.
> +- eth-handle: phandle, specifies a reference to a node
> +representing a ethernet device.
> +- dsaf-handle: phandle, specifies a reference to a node
> +representing a dsaf device.
> +- #address-cells: must be 2
> +- #size-cells: must be 2
> +Optional properties:
> +- dma-coherent: Present if DMA operations are coherent.
> +- interrupt-parent: the interrupt parent of this device.
> +- interrupts: should contain 32 completion event irq,1 async event irq
> +and 1 event overflow irq.

    The "interrupt-names" prop is very desirable for so many interrupts.

> +Example:
> +	rocee@0xc4000000 {

    The node names should be generic and "0x" should be omitted, i.e. 
"infiniband@c4000000".

MBR, Sergei