To: linux-kernel@vger.kernel.org, arnd@arndb.de, trivial@kernel.org
From: Gianfranco Costamagna <locutusofborg@debian.org>
Subject: [PATCH] ARM: LLVMLinux: Change "extern inline" to "static inline" in
 mpi-inline.h and mpi-internal.h
Message-ID: <56D99351.8080601@debian.org>
Date: Fri, 4 Mar 2016 14:53:21 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.5.1
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="IXOjHu1RqfB43m3AGk153H3vBLAFrglLn"
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 4661
Lines: 129

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--IXOjHu1RqfB43m3AGk153H3vBLAFrglLn
Content-Type: multipart/mixed; boundary="blUunQUAgwcciA2SMo2XNb6KE3LFWawdT"
From: Gianfranco Costamagna <locutusofborg@debian.org>
To: linux-kernel@vger.kernel.org, arnd@arndb.de, trivial@kernel.org
Message-ID: <56D99351.8080601@debian.org>
Subject: [PATCH] ARM: LLVMLinux: Change "extern inline" to "static inline" in
 mpi-inline.h and mpi-internal.h

--blUunQUAgwcciA2SMo2XNb6KE3LFWawdT
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Hi, this is my first contribution to the kernel code, I hope I did it rig=
ht.

Today I faced a gcc-5 build failure, so I fixed it (the static inline
C99 issue)

After I found the same patch from Arnd, but I fail to see it applied to
the kernel source code.

according to LKML [1] the patch should be already applied, but I fail to
see it in current master.

Sending it with the format-patch style.


[1] https://lkml.org/lkml/2016/2/26/459

=46rom 820a0ad32d474adf925437811e9b61d9d8886bc9 Mon Sep 17 00:00:00 2001
From: Gianfranco Costamagna <gianfranco.costamagna@abinsula.com>
Date: Fri, 4 Mar 2016 14:16:24 +0100
Subject: [PATCH] ARM: LLVMLinux: Change "extern inline" to "static
inline" in
 mpi-inline.h and mpi-internal.h

With compilers which follow the C99 standard (like modern versions of
gcc and
clang), "extern inline" does the wrong thing (emits code for an externall=
y
linkable version of the inline function). "static inline" is the correct
choice
instead.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Gianfranco Costamagna <gianfranco.costamagna@abinsula.com>=

Signed-off-by: Gianfranco Costamagna <locutusofborg@debian.org>
---
 lib/mpi/mpi-inline.h   | 2 +-
 lib/mpi/mpi-internal.h | 8 ++++----
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/lib/mpi/mpi-inline.h b/lib/mpi/mpi-inline.h
index e2b3985..c245ea3 100644
--- a/lib/mpi/mpi-inline.h
+++ b/lib/mpi/mpi-inline.h
@@ -30,7 +30,7 @@
 #define G10_MPI_INLINE_H

 #ifndef G10_MPI_INLINE_DECL
-#define G10_MPI_INLINE_DECL  extern inline
+#define G10_MPI_INLINE_DECL  static inline
 #endif

 G10_MPI_INLINE_DECL mpi_limb_t
diff --git a/lib/mpi/mpi-internal.h b/lib/mpi/mpi-internal.h
index c65dd1b..1baca30 100644
--- a/lib/mpi/mpi-internal.h
+++ b/lib/mpi/mpi-internal.h
@@ -168,19 +168,19 @@ void mpi_rshift_limbs(MPI a, unsigned int count);
 int mpi_lshift_limbs(MPI a, unsigned int count);

 /*-- mpihelp-add.c --*/
-mpi_limb_t mpihelp_add_1(mpi_ptr_t res_ptr, mpi_ptr_t s1_ptr,
+static mpi_limb_t mpihelp_add_1(mpi_ptr_t res_ptr, mpi_ptr_t s1_ptr,
 			 mpi_size_t s1_size, mpi_limb_t s2_limb);
 mpi_limb_t mpihelp_add_n(mpi_ptr_t res_ptr, mpi_ptr_t s1_ptr,
 			 mpi_ptr_t s2_ptr, mpi_size_t size);
-mpi_limb_t mpihelp_add(mpi_ptr_t res_ptr, mpi_ptr_t s1_ptr, mpi_size_t
s1_size,
+static mpi_limb_t mpihelp_add(mpi_ptr_t res_ptr, mpi_ptr_t s1_ptr,
mpi_size_t s1_size,
 		       mpi_ptr_t s2_ptr, mpi_size_t s2_size);

 /*-- mpihelp-sub.c --*/
-mpi_limb_t mpihelp_sub_1(mpi_ptr_t res_ptr, mpi_ptr_t s1_ptr,
+static mpi_limb_t mpihelp_sub_1(mpi_ptr_t res_ptr, mpi_ptr_t s1_ptr,
 			 mpi_size_t s1_size, mpi_limb_t s2_limb);
 mpi_limb_t mpihelp_sub_n(mpi_ptr_t res_ptr, mpi_ptr_t s1_ptr,
 			 mpi_ptr_t s2_ptr, mpi_size_t size);
-mpi_limb_t mpihelp_sub(mpi_ptr_t res_ptr, mpi_ptr_t s1_ptr, mpi_size_t
s1_size,
+static mpi_limb_t mpihelp_sub(mpi_ptr_t res_ptr, mpi_ptr_t s1_ptr,
mpi_size_t s1_size,
 		       mpi_ptr_t s2_ptr, mpi_size_t s2_size);

 /*-- mpihelp-cmp.c --*/
--=20
2.5.0


--blUunQUAgwcciA2SMo2XNb6KE3LFWawdT--

--IXOjHu1RqfB43m3AGk153H3vBLAFrglLn
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJW2ZNVAAoJEPNPCXROn13ZtfYP/jSGJJ0lWIFRhxrkKaQ0xJe4
aImyf3cDR3JUh1ElX5bo8S/5c+oOVwQU6bNz3qTs3lJaSKSRyxh8GLvbdWNxKgSj
7z09atdUI4YbSfUKmQ6xZ/sD6OQh7mf3pBGJpq+TjnqRb1V1z8S1MVY9FLijl+Cq
dNwq7Qj12kZi84gz9RRvVYF08AHJ3p+5P6DOe46+ly4fs+AFk2QGaCCNgmA82m0S
3elw8k7Fgabt1NBQAbJ6a4ARZhHAYISsKWvoprn6W6ajt6t1J/i5uApa33KiHb9/
fW3NSFUHYj9EB3MRilv9MWnYCd8TszasJiwE//5fFjPMAU11IArPX8QDuATyLKyY
65Tc0U+OX89ST7+XZvsJKsMfYu+w2KWAHHG0dNIVtR7COR08p6KwDCfiQr4wFegJ
oxo027l76dLdk4VLXwm8uKkH3DXbhgNmpfgBbqUlZIAxdNUznd3p+YV4MoxwlW+S
JmeC+02xVR8gXwlqDJCgyADNkK8p1pnvVemAT6psAgZJ9iueCPzXjcl54GoY1MhE
YVAxDm0BLimFcRFs1tAv7jOrRFlAeo0BzgN2xb87XJyaV5IdLYSMY9hVnY1ZklPU
B+Sx8DF1IVBNT2m+Yub0AxZP0S59P7jQAfkOo0Lpi/lClxd5yWJkc+/6i0UE5sIP
qG1UMwIPMvy8zEeFz9yn
=19tt
-----END PGP SIGNATURE-----

--IXOjHu1RqfB43m3AGk153H3vBLAFrglLn--