Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758924AbcCDP3g (ORCPT ); Fri, 4 Mar 2016 10:29:36 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:41043 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755146AbcCDP3d convert rfc822-to-8bit (ORCPT ); Fri, 4 Mar 2016 10:29:33 -0500 From: Kalle Valo To: Geert Uytterhoeven Cc: David Miller , Linus Torvalds , linux-wireless , "netdev\@vger.kernel.org" , "linux-kernel\@vger.kernel.org" , Larry.Finger@lwfinger.net Subject: Re: pull-request: wireless-drivers 2016-02-18 References: <87mvqyqbqp.fsf@kamboji.qca.qualcomm.com> Date: Fri, 04 Mar 2016 17:29:25 +0200 In-Reply-To: (Geert Uytterhoeven's message of "Mon, 29 Feb 2016 09:35:21 +0100") Message-ID: <87y49yw9be.fsf@kamboji.qca.qualcomm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1369 Lines: 44 (Adding Larry) Geert Uytterhoeven writes: > On Thu, Feb 18, 2016 at 4:28 PM, Kalle Valo wrote: > >> rtlwifi >> >> * fix broken VHT (802.11ac) support, reported by Linus > > That's commit d76d65fd26951498144029c24852c4d54ee512d9 > > drivers/net/wireless/realtek/rtlwifi/rc.c: In function > ‘_rtl_rc_rate_set_series’: > drivers/net/wireless/realtek/rtlwifi/rc.c:144: warning: comparison is > always false due to limited range of data type > > if (sta && sta->vht_cap.vht_supported && > (wireless_mode == WIRELESS_MODE_AC_5G || > wireless_mode == WIRELESS_MODE_AC_24G || > wireless_mode == WIRELESS_MODE_AC_ONLY)) > rate->flags |= IEEE80211_TX_RC_VHT_MCS; > > u8 wireless_mode = 0; > > enum wireless_mode { > ... > WIRELESS_MODE_AC_ONLY = 0x100, > > How is that supposed to work? I have no idea what could be the difference, for example, between AC_5G and AC_ONLY. Maybe AC_ONLY mode is not really used in normal setups and that's why the bug doesn't break anything? Larry, do you know? Anyway, Larry has a patch for this but I'm planning to send it to 4.6 as I didn't think it as that urgent: rtlwifi: Fix size of wireless mode variable https://patchwork.kernel.org/patch/8425191/ -- Kalle Valo