Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758553AbcCDPtT (ORCPT ); Fri, 4 Mar 2016 10:49:19 -0500 Received: from mga03.intel.com ([134.134.136.65]:7797 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751476AbcCDPtR (ORCPT ); Fri, 4 Mar 2016 10:49:17 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,536,1449561600"; d="scan'208";a="929681271" Message-ID: <1457106530.7064.52.camel@linux.intel.com> Subject: Re: [PATCH] goldfish: Fix build error of missing ioremap on UM From: Alan Cox To: Krzysztof Kozlowski , Jin Qian , Greg Kroah-Hartman , Greg Hackmann , Miodrag Dinic , linux-kernel@vger.kernel.org Date: Fri, 04 Mar 2016 15:48:50 +0000 In-Reply-To: <1456992829-23300-1-git-send-email-k.kozlowski@samsung.com> References: <1456992829-23300-1-git-send-email-k.kozlowski@samsung.com> Organization: Intel Corporation Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.5 (3.16.5-3.fc22) Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 665 Lines: 20 On Thu, 2016-03-03 at 17:13 +0900, Krzysztof Kozlowski wrote: > Add missing HAS_IOMEM dependency to fix the allyesconfig build error > on > ARCH=um (for x86_64): > > drivers/platform/goldfish/pdev_bus.c: In function > ‘goldfish_pdev_bus_probe’: > drivers/platform/goldfish/pdev_bus.c:191:18: error: implicit > declaration of function ‘ioremap’ [-Werror=implicit-function > -declaration] > pdev_bus_base = ioremap(pdev_bus_addr, pdev_bus_len); > > Signed-off-by: Krzysztof Kozlowski Reviewed-by: Alan Cox Thanks for that - I was trying to work out where that weird 0day complaint was coming from. Alan