Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759050AbcCDP55 (ORCPT ); Fri, 4 Mar 2016 10:57:57 -0500 Received: from mout.kundenserver.de ([212.227.126.135]:57751 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756332AbcCDP5z (ORCPT ); Fri, 4 Mar 2016 10:57:55 -0500 From: Arnd Bergmann To: Alexandre Courbot Cc: Ulf Hansson , Adrian Hunter , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, gnurou@gmail.com Subject: Re: [PATCH v3 2/3] mmc: sdhci-acpi: Remove enable_dma() hook Date: Fri, 04 Mar 2016 16:57:44 +0100 Message-ID: <2588443.l6d6cBKpRe@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1457087925-992-3-git-send-email-acourbot@nvidia.com> References: <1457087925-992-1-git-send-email-acourbot@nvidia.com> <1457087925-992-3-git-send-email-acourbot@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:bGjMNMbHXgldnsqf0qN4hjMdhbA/085ou3H4/JLN6mYPivW/msW C3sMoSBhe1f46BEaODfSE9o3svJouEMkTmE91TCXHHgWtPl0yVa9cy23hOamh2sBxmYCkRw iZ3QDCz2p+Y2YUyJIvJU/7Y2AbDNYOSvxQiOJMEZxmDN9LAVEAfQkA45hWFyfNcrZVMO1wr 4GUFEoB1HPR4GfBxLNiJg== X-UI-Out-Filterresults: notjunk:1;V01:K0:rhNi/t6gnjM=:hHNkb+nY2Wui8QxDwv6wiP rF6ELHbzJ1eu5Il8B0XqsP4IRWffrcOCoRAagQthvZ6ukQO0aaOij3xMxMMROIpV/Wgad1LVX T4jpnLE4s06DpWGPyGzOtlfIp5JmPTRyJqIIq83mTcEcE7yeQXKdUbVsQ2+EOPHsXHU1wMNpQ hkr1ZCKgnIfbASl8hGZ0NHnOVm0tjZukDfqzUsCgHkR2iP2UafXJEZz8pAtzaSumQ6WsR44yy VtVK55sZ+mcgvOe5uDewDsQ7pTParREaBjKOWJY0p0Tl3nqvqFICqH4yVqdBSx4FgU1m4Ri1X 39PKTX8JhTRCJ/Fi52oYkXX0tj/pgy9euvwg/leeoj+Hs7umHWOMMJXffhopJ4Cs8UaSFlZ4p MD5h75Nu45Pf5lqzKNbN97IuD0l4Mud6m98nW1wvot70KuRHXZBAwoDB4mgTTUobu3XdiUqt2 iISBVPiZPeyLaYRlBsa1R9wrgD8m4DOWKu6L4PJdpB0V6LiSFlUoUOIJkmyNRyZ63TnQ87pos XuGbCFLTYWH2PW9DsmgnFnsh3BsBt55NB7uwbfbMK/KGWW1SCCx26k3co8IDqcX7Vqsz8Dbeb WXizZLcNC6bX6LR7OiUuoBjucZbJ8fvhEsH6yB5hFWXFwAgCGYycSsemYXTYDaRL99vvT6mIG bnTfOtPhJnupoU8pV8REU6UU77VFSTZGr2NVmLk3GhKJtKw5Gna4kJMu66NF2Ozqkw/DiG9M7 Yx/fY9S/IUwPgs8y Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 407 Lines: 11 On Friday 04 March 2016 19:38:44 Alexandre Courbot wrote: > This hook was solely used to set the DMA mask, which is now done > by the newly-added sdhci_set_dma_mask() function. > > The use of a flag to ensure the mask is only set once is a strong hint > that it should not have been done there anyway. > > Signed-off-by: Alexandre Courbot > Acked-by: Arnd Bergmann