Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759194AbcCDP6V (ORCPT ); Fri, 4 Mar 2016 10:58:21 -0500 Received: from mout.kundenserver.de ([217.72.192.74]:51394 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759072AbcCDP6Q (ORCPT ); Fri, 4 Mar 2016 10:58:16 -0500 From: Arnd Bergmann To: Alexandre Courbot Cc: Ulf Hansson , Adrian Hunter , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, gnurou@gmail.com Subject: Re: [PATCH v3 3/3] mmc: sdhci-pci: Do not set DMA mask in enable_dma() Date: Fri, 04 Mar 2016 16:58:03 +0100 Message-ID: <80995892.bmuuFVee6i@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1457087925-992-4-git-send-email-acourbot@nvidia.com> References: <1457087925-992-1-git-send-email-acourbot@nvidia.com> <1457087925-992-4-git-send-email-acourbot@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:u6sG2tbR4Cwfua5tRPQj8I49Ooa69wwzmHdB2bFLBCzJYbgub+K H9VzKCjF/WvN2nwbc2SpVEveZ7lVROiOd4aIod3SpcCULx1LFWrt/7Hhhxiv1DHqT8CcvnZ CUcpQ3kdPxRxqrWUgRwW/mZYvMCjXly5P8ItqAvYi5E4i2xRXD+8ofeYydFZOfa4xaH+99i oyCRG5HE8Zstrs/Z3BCig== X-UI-Out-Filterresults: notjunk:1;V01:K0:6gBsc2KzNSY=:F+uaen5SioBWR0GLj0qal2 hyrREBUgQRbLpHEZ6Zvnx0s8qa6SPn2c4EOTEfxz9UrtC+IreW4uBLCKfvrI0VglzXzLOM3W0 GAHlEeFo1lgRwW+GyNYbZ/POOnDPd5CgCFT701Wir/WJIw2WKgaZDFU3zQxN2jwu2ZilWpW7L uq4Q/INV6midw92KnyE8W4jOLmZSFTX5Nux8S9X5kOmHMI1hFeeNLfXmzLyxirjvx+yFnlhRw jwDTGQ1uKYK42FrR3jWos7ZGGXekYyqUcM5RMdgwgFWDHKcSSC1Z/VICJ2ndJiInekLNlzymd qDG4BmcECFA4fc2tdRfvCBzstAl0JIp8ecP5ZVQTjIkCPjHZxpVp3MmZOXQTRlXTEHiKpT/Sc DgnKp+s1CLaxtjU6QctIpmhDlMNlJq5kU9aR2ZrGk0G7Fzzj2y92Xz384QvCV8dLu/HmCiqIP EnYljfdJlYw9y+z+UhogfuyLNYzhWZ+vpf+jaRO4ohP4ZeYBA/TNGnYdeSGImHyr2NPdzWlcZ aOO27Q9W+btmPDaMcz+AoVA/L21rmoRWBtuRU+8UVUoq0Ne7bM2CJss9P+QOLEq1RlcGSMUQ+ KciILthcSl2/rfEl6y3aNY52uL6+GqY5pvy49ov59NGXgar5wXOr4GCJu1GytvpS/HpSWjfOW kQFXUIMTnatNJrSD6N2AE6tT23tUp6v250Kw0048EcGMdF5XEuX/vKbq4pe+fBW9t5vApO1/R 1Tb2Ou6oGUErwh6x Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 392 Lines: 11 On Friday 04 March 2016 19:38:45 Alexandre Courbot wrote: > DMA mask will already be set by sdhci_set_dma_mask(), which > is equivalent to the removed code since pci_set_dma_mask() > expands to its DMA-API counterpart. > > There should also be no reason to set the DMA mask after probe. > > Signed-off-by: Alexandre Courbot > Acked-by: Arnd Bergmann