Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760003AbcCDQXc (ORCPT ); Fri, 4 Mar 2016 11:23:32 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:43320 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754012AbcCDQXa (ORCPT ); Fri, 4 Mar 2016 11:23:30 -0500 Subject: Re: [PATCH] gpio: omap: drop dev field from gpio_bank structure To: Grygorii Strashko , Linus Walleij , Alexandre Courbot , ssantosh@kernel.org, tony@atomide.com References: <1457105135-28124-1-git-send-email-grygorii.strashko@ti.com> Cc: linux-omap@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org From: santosh shilimkar Organization: Oracle Corporation Message-ID: <56D9B66E.7020807@oracle.com> Date: Fri, 4 Mar 2016 08:23:10 -0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <1457105135-28124-1-git-send-email-grygorii.strashko@ti.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 402 Lines: 12 On 3/4/2016 7:25 AM, Grygorii Strashko wrote: > GPIO chip structure already has "parent" field which is used for the > same purpose as "dev" field in gpio_bank structure - store pointer on > GPIO device. > > Hence, drop duplicated "dev" field from gpio_bank structure. > > Signed-off-by: Grygorii Strashko > --- Looks good. Acked-by: Santosh Shilimkar