Subject: Re: [PATCH] null_blk: add lightnvm null_blk device to the nullb_list
To: Wenwei Tao <ww.tao0320@gmail.com>
References: <1457108824-3792-1-git-send-email-ww.tao0320@gmail.com>
CC: <linux-kernel@vger.kernel.org>, <linux-block@vger.kernel.org>,
        Matias Bjorling <m@bjorling.me>
From: Jens Axboe <axboe@fb.com>
Message-ID: <56D9B8C5.2090801@fb.com>
Date: Fri, 4 Mar 2016 09:33:09 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.5.1
MIME-Version: 1.0
In-Reply-To: <1457108824-3792-1-git-send-email-ww.tao0320@gmail.com>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 850
Lines: 33

On 03/04/2016 09:27 AM, Wenwei Tao wrote:
> After register null_blk devices into lightnvm, we forget
> to add these devices to the the nullb_list, makes them
> invisible to the null_blk driver.
>
> Signed-off-by: Wenwei Tao <ww.tao0320@gmail.com>
> ---
>   drivers/block/null_blk.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/block/null_blk.c b/drivers/block/null_blk.c
> index 64a7b59..cab9759 100644
> --- a/drivers/block/null_blk.c
> +++ b/drivers/block/null_blk.c
> @@ -742,10 +742,11 @@ static int null_add_dev(void)
>
>   	add_disk(disk);
>
> +done:
>   	mutex_lock(&lock);
>   	list_add_tail(&nullb->list, &nullb_list);
>   	mutex_unlock(&lock);
> -done:
> +
>   	return 0;
>
>   out_cleanup_lightnvm:

Thanks, that looks like a regression caused by a514379b0c77, I'll add a 
Fixes tag.

-- 
Jens Axboe