User-Agent: K-9 Mail for Android
In-Reply-To: <56D9424C.201@ladisch.de>
References: <1456947640-20673-1-git-send-email-eu@felipetonello.com> <1456947640-20673-2-git-send-email-eu@felipetonello.com> <56D7567A.40402@ladisch.de> <56D7FC6B.7040709@felipetonello.com> <56D82237.2080705@ladisch.de> <56D866A1.5060303@felipetonello.com> <56D9424C.201@ladisch.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain;
 charset=UTF-8
Subject: Re: [PATCH 1/5] usb: gadget: f_midi: refactor state machine
From: Felipe Ferreri Tonello <eu@felipetonello.com>
Date: Fri, 04 Mar 2016 18:39:34 +0000
To: Clemens Ladisch <clemens@ladisch.de>, linux-usb@vger.kernel.org
CC: linux-kernel@vger.kernel.org, Felipe Balbi <balbi@kernel.org>,
        Michal Nazarewicz <mina86@mina86.com>
Message-ID: <25A6D99D-E187-40AB-AB2B-0FE2CDFF922B@felipetonello.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1025
Lines: 29

Hi Clemens, 

On March 4, 2016 8:07:40 AM GMT+00:00, Clemens Ladisch <clemens@ladisch.de> wrote:
>Felipe Ferreri Tonello wrote:
>> On 03/03/16 11:38, Clemens Ladisch wrote:
>>> But in what way was the old state machine not "proper"?
>>
>> Because it didn't reflect all the correct and possible MIDI states
>
>The whole point of the one-byte real-time messages is that they do not
>affect the parsing of the surrounding MIDI stream.  So not making them
>part of the state machine is the proper way of handling them.  (Also
>see the flowchart in appendix A of the spec.)

I really don't get your point. So why do we have a state machine at all? 

>
>> This patch doesn't change any functionality. But the important thing
>> here is that it improves the driver maintainability [...]
>
>Then I won't get in the way of this driver's maintainer.


Clemens, I really value your feedback. I just want to understand what's the problem of this patch. 

Felipe 

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.