Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760065AbcCDThL (ORCPT ); Fri, 4 Mar 2016 14:37:11 -0500 Received: from spo001.leaseweb.nl ([83.149.101.17]:48330 "EHLO spo001.leaseweb.nl" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1758968AbcCDThK (ORCPT ); Fri, 4 Mar 2016 14:37:10 -0500 Date: Fri, 4 Mar 2016 20:37:07 +0100 From: Wim Van Sebroeck To: Thierry Reding Cc: Guenter Roeck , linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] watchdog: orion: Depend on 32-bit ARM Message-ID: <20160304193707.GC6900@spo001.leaseweb.nl> References: <1456323726-20234-1-git-send-email-thierry.reding@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1456323726-20234-1-git-send-email-thierry.reding@gmail.com> User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1063 Lines: 35 Hi Thierry, > From: Thierry Reding > > The driver uses the atomic_io_modify() function to update registers, but > that function is only available on 32-bit ARM. Recent changes have added > ARCH_MVEBU support to 64-bit ARM and hence allowed this driver to build > on 64-bit ARM where this function isn't available and thereby causing > allmodconfig builds to break. > > Signed-off-by: Thierry Reding > --- > drivers/watchdog/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig > index 9289da313d98..cfec157488b1 100644 > --- a/drivers/watchdog/Kconfig > +++ b/drivers/watchdog/Kconfig > @@ -399,6 +399,7 @@ config DAVINCI_WATCHDOG > config ORION_WATCHDOG > tristate "Orion watchdog" > depends on ARCH_ORION5X || ARCH_DOVE || MACH_DOVE || ARCH_MVEBU > + depends on ARM > select WATCHDOG_CORE > help > Say Y here if to include support for the watchdog timer > -- > 2.7.1 > Patch has been added to linux-watchdog-next. Kind regards, Wim.