Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760348AbcCDVgb (ORCPT ); Fri, 4 Mar 2016 16:36:31 -0500 Received: from mail-wm0-f68.google.com ([74.125.82.68]:36225 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760324AbcCDVg1 (ORCPT ); Fri, 4 Mar 2016 16:36:27 -0500 MIME-Version: 1.0 In-Reply-To: <1457088739-1065-4-git-send-email-nicolas.dichtel@6wind.com> References: <20160303.170804.2300821465150459193.davem@davemloft.net> <1457088739-1065-1-git-send-email-nicolas.dichtel@6wind.com> <1457088739-1065-4-git-send-email-nicolas.dichtel@6wind.com> Date: Fri, 4 Mar 2016 21:36:25 +0000 Message-ID: Subject: Re: [PATCH net-next v3 3/4] drm/vmwgfx: remove userland definition of DIV_ROUND_UP From: Emil Velikov To: Nicolas Dichtel , Thomas Hellstrom Cc: "David S. Miller" , linux-scsi@vger.kernel.org, netdev@vger.kernel.org, "Linux-Kernel@Vger. Kernel. Org" , ML dri-devel , Karen Xie , ben@decadent.org.uk Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1210 Lines: 33 Hi Nicolas, On 4 March 2016 at 10:52, Nicolas Dichtel wrote: > Let's use __KERNEL_DIV_ROUND_UP, which is defined in uapi/linux/kernel.h. > > Signed-off-by: Nicolas Dichtel > --- > .../drm/vmwgfx/device_include/svga3d_surfacedefs.h | 20 +++++++++++--------- > 1 file changed, 11 insertions(+), 9 deletions(-) > > diff --git a/drivers/gpu/drm/vmwgfx/device_include/svga3d_surfacedefs.h b/drivers/gpu/drm/vmwgfx/device_include/svga3d_surfacedefs.h > index 58704f0a4607..531d22025fec 100644 > --- a/drivers/gpu/drm/vmwgfx/device_include/svga3d_surfacedefs.h > +++ b/drivers/gpu/drm/vmwgfx/device_include/svga3d_surfacedefs.h > @@ -25,6 +25,8 @@ > * > **************************************************************************/ > > +#include > + Files from DRM modules tend to be used in various (crazy) ways. Be that in linux and/or other user space. Fairly certain that everything is fine here, just adding one of the core vmwgfx developers. Thomas, this won't cause any issues would it ? Can you guys please add an entry for vmwgfx to MAINTAINERS, so that people can CC you guys on patches that touch the driver ? Thanks Emil