Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760572AbcCDXZK (ORCPT ); Fri, 4 Mar 2016 18:25:10 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:45507 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760369AbcCDXZI (ORCPT ); Fri, 4 Mar 2016 18:25:08 -0500 Date: Fri, 4 Mar 2016 15:25:07 -0800 From: Andrew Morton To: Vlastimil Babka Cc: Joonsoo Kim , Joonsoo Kim , Linux Memory Management List , LKML , Andrea Arcangeli , "Kirill A. Shutemov" , Rik van Riel , Mel Gorman , David Rientjes , Michal Hocko , Johannes Weiner Subject: Re: [PATCH v2 4/5] mm, kswapd: replace kswapd compaction with waking up kcompactd Message-Id: <20160304152507.18b1362f51b0860a1268a977@linux-foundation.org> In-Reply-To: <56D70543.60806@suse.cz> References: <1454938691-2197-1-git-send-email-vbabka@suse.cz> <1454938691-2197-5-git-send-email-vbabka@suse.cz> <20160302063322.GB32695@js1304-P5Q-DELUXE> <56D6BACB.7060005@suse.cz> <56D6F41D.9080107@suse.cz> <56D6FB77.2090801@suse.cz> <56D70543.60806@suse.cz> X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1912 Lines: 35 On Wed, 2 Mar 2016 16:22:43 +0100 Vlastimil Babka wrote: > On 03/02/2016 03:59 PM, Joonsoo Kim wrote: > > 2016-03-02 23:40 GMT+09:00 Vlastimil Babka : > >> On 03/02/2016 03:22 PM, Joonsoo Kim wrote: > >> > >> So I understand that patch 5 would be just about this? > >> > >> - if (compaction_restarting(zone, cc->order) && !current_is_kcompactd()) > >> + if (compaction_restarting(zone, cc->order)) > >> __reset_isolation_suitable(zone); > > > > Yeah, you understand correctly. :) > > > >> I'm more inclined to fold it in that case. > > > > Patch would be just simple, but, I guess it would cause some difference > > in test result. But, I'm okay for folding. > > Thanks. Andrew, should I send now patch folding patch 4/5 and 5/5 with > all the accumulated fixlets (including those I sent earlier today) and > combined changelog, or do you want to apply the new fixlets separately > first and let them sit for a week or so? In any case, sorry for the churn. Did I get everything? http://ozlabs.org/~akpm/mmots/broken-out/mm-kswapd-remove-bogus-check-of-balance_classzone_idx.patch http://ozlabs.org/~akpm/mmots/broken-out/mm-compaction-introduce-kcompactd.patch http://ozlabs.org/~akpm/mmots/broken-out/mm-compaction-introduce-kcompactd-fix.patch http://ozlabs.org/~akpm/mmots/broken-out/mm-compaction-introduce-kcompactd-fix-2.patch http://ozlabs.org/~akpm/mmots/broken-out/mm-compaction-introduce-kcompactd-fix-3.patch http://ozlabs.org/~akpm/mmots/broken-out/mm-memory-hotplug-small-cleanup-in-online_pages.patch http://ozlabs.org/~akpm/mmots/broken-out/mm-kswapd-replace-kswapd-compaction-with-waking-up-kcompactd.patch http://ozlabs.org/~akpm/mmots/broken-out/mm-kswapd-replace-kswapd-compaction-with-waking-up-kcompactd-fix.patch http://ozlabs.org/~akpm/mmots/broken-out/mm-compaction-adapt-isolation_suitable-flushing-to-kcompactd.patch