Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760246AbcCECz1 (ORCPT ); Fri, 4 Mar 2016 21:55:27 -0500 Received: from mail-pf0-f193.google.com ([209.85.192.193]:33883 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759575AbcCECzY (ORCPT ); Fri, 4 Mar 2016 21:55:24 -0500 Subject: Re: [PATCH v11 17/24] perf config: Collect configs to handle config variables To: Namhyung Kim References: <1447768424-17327-1-git-send-email-treeze.taeung@gmail.com> <1447768424-17327-17-git-send-email-treeze.taeung@gmail.com> <20151118051525.GP7062@sejong> <56D98378.4080208@gmail.com> <20160304135848.GA15486@danjae.kornet> Cc: Arnaldo Carvalho de Melo , linux-kernel@vger.kernel.org, Ingo Molnar , Jiri Olsa , perf group , Peter Zijlstra From: Taeung Song Message-ID: <56DA4A98.1000708@gmail.com> Date: Sat, 5 Mar 2016 11:55:20 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20160304135848.GA15486@danjae.kornet> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 955 Lines: 37 On 03/04/2016 10:58 PM, Namhyung Kim wrote: > Hi Taeung, > > On Fri, Mar 04, 2016 at 09:45:44PM +0900, Taeung Song wrote: >> Hi, Namhyung and all >> >> (I'm modifying this patch to be tidy) >> I have a mere question about name of a variable for >> current config list that contains section list which has key-value >> pairs from ~/.perfconfig or $(sysconfdir)/perfconfig config file. >> >> (This variable is designed to be used by several functions >> that handle config information(key-value pairs).) >> >> I used 'sections' for this variable (type is 'struct list_head'), >> but IMHO, I think that renaming it is better e.g. >> >> 1) 'cfglist' >> 2) 'configlist' >> 3) 'config_list' >> 4) 'cfgset' >> 5) 'configset' >> 6) 'config_set' >> ... :-\ >> >> It is trivial question, >> but I wanna know a opinion of other people. :-) > > I'd go with 3 or 6. Or simply 'configs' or 'perf_configs' is fine for > me. > Thank you for your opinion. :-) Taeung