Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760464AbcCEDHh (ORCPT ); Fri, 4 Mar 2016 22:07:37 -0500 Received: from mail-pa0-f54.google.com ([209.85.220.54]:33628 "EHLO mail-pa0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759709AbcCEDHg (ORCPT ); Fri, 4 Mar 2016 22:07:36 -0500 Date: Fri, 4 Mar 2016 19:07:33 -0800 From: Brian Norris To: Robert Jarzmik Cc: Ezequiel Garcia , David Woodhouse , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mtd: nand: pxa3xx_nand: fix dmaengine initialization Message-ID: <20160305030733.GQ55664@google.com> References: <1455316144-14464-1-git-send-email-robert.jarzmik@free.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1455316144-14464-1-git-send-email-robert.jarzmik@free.fr> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 691 Lines: 16 On Fri, Feb 12, 2016 at 11:29:04PM +0100, Robert Jarzmik wrote: > When the driver is initialized in a pure device-tree platform, the > driver's probe fails allocating the dma channel : > [ 525.624435] pxa3xx-nand 43100000.nand: no resource defined for data DMA > [ 525.632088] pxa3xx-nand 43100000.nand: alloc nand resource failed > > The reason is that the DMA IO resource is not acquired through platform > resources but by OF bindings. > > Fix this by ensuring that DMA IO resources are only queried in the non > device-tree case. > > Fixes: 8f5ba31aa565 ("mtd: nand: pxa3xx-nand: switch to dmaengine") > Signed-off-by: Robert Jarzmik Applied to l2-mtd.git