Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760856AbcCEEbz (ORCPT ); Fri, 4 Mar 2016 23:31:55 -0500 Received: from mail.kernel.org ([198.145.29.136]:49256 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760727AbcCEEbv (ORCPT ); Fri, 4 Mar 2016 23:31:51 -0500 Date: Fri, 4 Mar 2016 22:31:42 -0600 From: Rob Herring To: Alexandre TORGUE Cc: Maxime Coquelin , Giuseppe Cavallaro , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, manabian@gmail.com Subject: Re: [PATCH v4 2/4] Documentation: Bindings: Add STM32 DWMAC glue Message-ID: <20160305043142.GK13525@rob-hp-laptop> References: <1457107086-14764-1-git-send-email-alexandre.torgue@gmail.com> <1457107086-14764-3-git-send-email-alexandre.torgue@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1457107086-14764-3-git-send-email-alexandre.torgue@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1874 Lines: 52 On Fri, Mar 04, 2016 at 04:58:04PM +0100, Alexandre TORGUE wrote: > Signed-off-by: Alexandre TORGUE > > diff --git a/Documentation/devicetree/bindings/net/stm32-dwmac.txt b/Documentation/devicetree/bindings/net/stm32-dwmac.txt > new file mode 100644 > index 0000000..fd3566f > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/stm32-dwmac.txt > @@ -0,0 +1,35 @@ > +STMicroelectronics STM32 / MCU DWMAC glue layer controller > + > +This file documents platform glue layer for stmmac. > +Please see stmmac.txt for the other unchanged properties. > + > +The device node has following properties. > + > +Required properties: > +- compatible: Should be "st,stm32-dwmac" to select glue, and > + "snps,dwmac-3.50a" to select IP vesrion. > +- clocks: Should contain the GMAC main clock, and tx clock > +- compatible: Should be "st,stm32-dwmac" to select glue and > + "snps,dwmac-3.50a" to select IP version. > +- clocks: Must contain an entry for each entry in clock-names. ??? > +- clock-names: Should be "stmmaceth" for the host clock. > + Should be "tx-clk" for the MAC TX clock. > + Should be "rx-clk" for the MAC RX clock. > +- st,syscon : Should be phandle/offset pair. The phandle to the syscon node which > + encompases the glue register, and the offset of the control register. > +Example: > + > + ethernet0: dwmac@40028000 { > + compatible = "st,stm32-dwmac", "snps,dwmac-3.50a"; > + status = "disabled"; > + reg = <0x40028000 0x8000>; > + reg-names = "stmmaceth"; > + interrupts = <0 61 0>, <0 62 0>; > + interrupt-names = "macirq", "eth_wake_irq"; > + clock-names = "stmmaceth", "tx-clk", "rx-clk"; > + clocks = <&rcc 0 25>, <&rcc 0 26>, <&rcc 0 27>; > + st,syscon = <&syscfg 0x4>; > + snps,pbl = <8>; > + snps,mixed-burst; > + dma-ranges; > + }; > -- > 1.9.1 >