Date: Sat, 5 Mar 2016 00:00:59 -0500
From: "David Rivshin (Allworx)" <drivshin.allworx@gmail.com>
To: Stefan Wahren <stefan.wahren@i2se.com>
Cc: linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
        Pawel Moll <pawel.moll@arm.com>, Rob Herring <robh+dt@kernel.org>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Kumar Gala <galak@codeaurora.org>, linux-kernel@vger.kernel.org,
        Jacek Anaszewski <j.anaszewski@samsung.com>,
        Richard Purdie <rpurdie@rpsys.net>,
        Mark Rutland <mark.rutland@arm.com>
Subject: Re: [PATCH 4/4] leds: Replace dedicated SN3218 driver with
 IS31FL32XX driver
Message-ID: <20160305000059.519c3b14.drivshin.allworx@gmail.com>
In-Reply-To: <1872003451.86198.4bb16da4-d4d8-48af-950a-7442cddf2b4d.open-xchange@email.1und1.de>
References: <1456974095-1867-1-git-send-email-drivshin.allworx@gmail.com>
	<1456974095-1867-5-git-send-email-drivshin.allworx@gmail.com>
	<1872003451.86198.4bb16da4-d4d8-48af-950a-7442cddf2b4d.open-xchange@email.1und1.de>
Organization: Allworx
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1358
Lines: 38

On Fri, 4 Mar 2016 22:14:27 +0100 (CET)
Stefan Wahren <stefan.wahren@i2se.com> wrote:

> Hi David,
> 
> > "David Rivshin (Allworx)" <drivshin.allworx@gmail.com> hat am 3. März 2016 um
> > 04:01 geschrieben:
> >
> >
> > From: David Rivshin <drivshin@allworx.com>
> >
> > Si-En Technology was acquired by ISSI in 2011, and it appears that
> > the IS31FL3218/IS31FL3216 are just rebranded SN3218/SN3216 devices.
> > As the IS31FL32XX driver already handles the *3218 devices, there
> > is no longer a need for the dedicated SN3218 driver.
> >
> > Add the "sn,sn3218" and "sn,sn3216" compatible strings into the
> > IS31FL32XX driver and binding documentation, and remove the
> > leds-sn3218 driver.
> >
> > Datasheets:
> > IS31FL3218: http://www.issi.com/WW/pdf/31FL3218.pdf
> > SN3218: http://www.si-en.com/uploadpdf/s2011517171720.pdf
> >
> > IS31FL3216: http://www.issi.com/WW/pdf/31FL3216.pdf
> > SN3216; http://www.si-en.com/uploadpdf/SN3216201152410148.pdf
> >
> > Signed-off-by: David Rivshin <drivshin@allworx.com>  
> 
> i tested this patch successfully with a Raspberry Pi and a PiGlow (SN3218).
> 
> Tested-by: Stefan Wahren <stefan.wahren@i2se.com>

Thanks very much for testing!

The PiGlow looks interesting, if I had known about it I might have just
ordered one for testing myself. Looks rather easier to hook up than the 
ISSI 3216 eval board.