Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759903AbcCEIpe (ORCPT ); Sat, 5 Mar 2016 03:45:34 -0500 Received: from smtp05.smtpout.orange.fr ([80.12.242.127]:35985 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755102AbcCEIp1 (ORCPT ); Sat, 5 Mar 2016 03:45:27 -0500 X-ME-Helo: belgarion X-ME-Auth: amFyem1pay5yb2JlcnRAb3JhbmdlLmZy X-ME-Date: Sat, 05 Mar 2016 09:45:24 +0100 X-ME-IP: 92.149.62.249 From: Robert Jarzmik To: Arnd Bergmann Cc: Brian Norris , David Woodhouse , linux-arm-kernel@lists.infradead.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, Haojian Zhuang , Daniel Mack Subject: Re: [PATCH] mtd: only use __xipram annotation when XIP_KERNEL is set References: <1453736525-1959191-2-git-send-email-arnd@arndb.de> <20160305000225.GB55664@google.com> <20160305001057.GC55664@google.com> <3582240.H8v1IXn8EB@wuerfel> X-URL: http://belgarath.falguerolles.org/ Date: Sat, 05 Mar 2016 09:45:21 +0100 In-Reply-To: <3582240.H8v1IXn8EB@wuerfel> (Arnd Bergmann's message of "Sat, 05 Mar 2016 01:24:36 +0100") Message-ID: <8737s5wbxa.fsf@belgarion.home> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 454 Lines: 17 Arnd Bergmann writes: > I guess we can bring back the macros for the case that MTD_XIP and XIP_KERNEL > are both enabled. > > Arnd I wouldn't have ICMR and ICIP exposed to drivers, Eric's original move looks corect to me. On the other hand, I'm wondering if xip_irqpending(), xip_currtime() and xip_cpu_idle() should be declared as functions in mtd-xip.h, and be part of something like arch/arm/mach-pxa/xip.c ... Cheers. -- Robert