Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760185AbcCEIxS (ORCPT ); Sat, 5 Mar 2016 03:53:18 -0500 Received: from kamaji.grokhost.net ([87.117.218.43]:51958 "EHLO kamaji.grokhost.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752232AbcCEIxL convert rfc822-to-8bit (ORCPT ); Sat, 5 Mar 2016 03:53:11 -0500 X-Greylist: delayed 444 seconds by postgrey-1.27 at vger.kernel.org; Sat, 05 Mar 2016 03:53:10 EST Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Subject: Re: [patch] sbp-target: checking for NULL instead of IS_ERR From: Chris Boot In-Reply-To: <1457163214.19657.288.camel@haakon3.risingtidesystems.com> Date: Sat, 5 Mar 2016 08:45:42 +0000 Cc: Dan Carpenter , target-devel@vger.kernel.org, linux1394-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Content-Transfer-Encoding: 8BIT Message-Id: <2A1ED37C-C556-4B3D-A59B-3369E5DFB4D5@bootc.net> References: <20160302100912.GD5533@mwanda> <1457163214.19657.288.camel@haakon3.risingtidesystems.com> To: "Nicholas A. Bellinger" X-Mailer: Apple Mail (2.3124) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1850 Lines: 53 On 5 Mar 2016, at 07:33, Nicholas A. Bellinger wrote: > > Hi Dan + BootC, > > On Wed, 2016-03-02 at 13:09 +0300, Dan Carpenter wrote: >> We changed this from kzalloc to sbp_mgt_get_req() so we need to change >> from checking for NULL to check for error pointers. >> >> Fixes: c064b2a78989 ('sbp-target: Conversion to percpu_ida tag pre-allocation') >> Signed-off-by: Dan Carpenter >> >> diff --git a/drivers/target/sbp/sbp_target.c b/drivers/target/sbp/sbp_target.c >> index 251d532..a04b0605f 100644 >> --- a/drivers/target/sbp/sbp_target.c >> +++ b/drivers/target/sbp/sbp_target.c >> @@ -951,7 +951,7 @@ static void tgt_agent_fetch_work(struct work_struct *work) >> >> while (next_orb && tgt_agent_check_active(agent)) { >> req = sbp_mgt_get_req(sess, sess->card, next_orb); >> - if (!req) { >> + if (IS_ERR(req)) { >> spin_lock_bh(&agent->lock); >> agent->state = AGENT_STATE_DEAD; >> spin_unlock_bh(&agent->lock); > > Fixed + folded into the original patch. > > Thanks Dan. > > Chris, would you be so kind to review the original changes here: > > sbp-target: Conversion to percpu_ida tag pre-allocation > http://www.spinics.net/lists/target-devel/msg11778.html > > sbp-target: Convert to TARGET_SCF_ACK_KREF I/O krefs > http://www.spinics.net/lists/target-devel/msg11780.html > > and verify on your local IEEE1394 target setup..? Hi Nic, Dan, I’m away this weekend so I can’t test these for a few days at least, unfortunately. I must admit I only vaguely follow the changes here as I haven’t been keeping up with the pace of change in target-devel lately, but it generally looks OK I think. Are these in linux-next or another branch somewhere I can easily clone them from? How soon do you need my ACK/NAK on these? Cheers, Chris -- Chris Boot bootc@bootc.net