Subject: Re: [PATCH V2 0/8] iommu/amd: enable ACPI hardware ID device support
To: "Wan, Vincent" <Vincent.Wan@amd.com>, Joerg Roedel <joro@8bytes.org>
References: <1453850077-2539-1-git-send-email-vincent.wan@amd.com>
 <20160226144446.GG22747@8bytes.org>
 <DM3PR1201MB10235E51027C3330C9BAF888E6BE0@DM3PR1201MB1023.namprd12.prod.outlook.com>
 <20160304084624.GA21839@8bytes.org>
 <CY1PR1201MB1019F37D828D88814896B798E6BE0@CY1PR1201MB1019.namprd12.prod.outlook.com>
CC: "iommu@lists.linux-foundation.org" <iommu@lists.linux-foundation.org>,
        Borislav Petkov <bp@suse.de>, "Huang, Ray" <Ray.Huang@amd.com>,
        "Xue, Ken" <Ken.Xue@amd.com>, "vw@iommu.org" <vw@iommu.org>,
        "mcuos.com@gmail.com" <mcuos.com@gmail.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Long, Gang" <Gang.Long@amd.com>
From: Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com>
Message-ID: <56DAA029.7040504@amd.com>
Date: Sat, 5 Mar 2016 16:00:25 +0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.5.1
MIME-Version: 1.0
In-Reply-To: <CY1PR1201MB1019F37D828D88814896B798E6BE0@CY1PR1201MB1019.namprd12.prod.outlook.com>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Mar 2016 09:00:41.0485
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR12MB0434
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1193
Lines: 40

Hi Joerg,

On 03/04/2016 03:49 PM, Wan, Vincent wrote:
>>> Joerg,
>>> Can you provide me which branch you are using to test those patches.
>>>
>>> We are validating the patches in v4.5.0-rc6, and no issues like your
>> description.
>>
>> I tested them on v4.5-rc5.
>>
> Thanks!
> We will test the patches basing on this v4.5-rc5 version again.
>
> Vincent.
>>
>> 	Joerg
>

I found the issue now. I'll work with Vincent to send out V3.

The problem is because in the information in the IOMMU Attributes field 
of the IVHD header type 40h (offset byte 20 = struct 
ivhd_header.efr_attr) is incorrect. It was correct in the IVHD type 
10h.... Sigh :(

However, the same information in the MMIO offset 4000h Counter 
configuration Register is correct. So, I'll try to have the patch get 
information from here instead.

Earlier, we had another issue with IOMMU PERF intialization, and it was 
disabled. So, it hides this bug when we were testing the patch earlier.
Now that we had a workaround for that bug n v4.5-rc5, it bombs in the 
init_iommu_perf_ctr().

So, if you want to test out the rest of this patch series, just simply 
comment out this function, and it should boot.

Regards,
Suravee