Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750754AbcCEQXF (ORCPT ); Sat, 5 Mar 2016 11:23:05 -0500 Received: from mail-io0-f194.google.com ([209.85.223.194]:33074 "EHLO mail-io0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750699AbcCEQW6 (ORCPT ); Sat, 5 Mar 2016 11:22:58 -0500 MIME-Version: 1.0 In-Reply-To: <1457192586-25596-14-git-send-email-vishnupatekar0510@gmail.com> References: <1457192586-25596-1-git-send-email-vishnupatekar0510@gmail.com> <1457192586-25596-14-git-send-email-vishnupatekar0510@gmail.com> From: Vishnu Patekar Date: Sun, 6 Mar 2016 00:22:37 +0800 Message-ID: Subject: Re: [PATCH v3 13/13] ARM: sunxi: Add Kconfig for sunxi clocks To: "robh+dt@kernel.org" , Jonathan Corbet , "pawel.moll@arm.com" , "mark.rutland@arm.com" , "ijc+devicetree@hellion.org.uk" , Kumar Gala , "maxime.ripard@free-electrons.com" , "linux@arm.linux.org.uk" , Emilio Lopez Cc: Jens Kuske , Hans de Goede , Chen-Yu Tsai , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-sunxi@googlegroups.com" , linux-gpio@vger.kernel.org, Linus Walleij , Michael Turquette , Stephen Boyd , Reinder de Haan , linux-clk Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1940 Lines: 61 Hello, On Sat, Mar 5, 2016 at 11:43 PM, Vishnu Patekar wrote: > This patch adds Kconfig for sunxi clocks. > Currently, only sun8i-apb0 and sun9i-cpus clocks are added. > It'll help to use common clocks across different SOCs. > We can switch to kconfig for other clocks in future. > > Signed-off-by: Vishnu Patekar > --- > drivers/clk/Kconfig | 1 + > drivers/clk/sunxi/Kconfig | 5 +++++ > drivers/clk/sunxi/Makefile | 4 ++-- > 3 files changed, 8 insertions(+), 2 deletions(-) > create mode 100644 drivers/clk/sunxi/Kconfig > > diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig > index eca8e01..f9f42e6 100644 > --- a/drivers/clk/Kconfig > +++ b/drivers/clk/Kconfig > @@ -210,3 +210,4 @@ source "drivers/clk/mvebu/Kconfig" > > source "drivers/clk/samsung/Kconfig" > source "drivers/clk/tegra/Kconfig" > +source "drivers/clk/sunxi/Kconfig" > diff --git a/drivers/clk/sunxi/Kconfig b/drivers/clk/sunxi/Kconfig > new file mode 100644 > index 0000000..afc55c9 > --- /dev/null > +++ b/drivers/clk/sunxi/Kconfig > @@ -0,0 +1,5 @@ > +config CLK_SUN8I_APB0 > + def_bool MACH_SUN9I || MACH_SUN8I_A83T This should be MACH_SUN8I and not MACH_SUN8I_A83T. Self NACK for this patch. > + > +config CLK_SUN9I_CPUS > + def_bool MACH_SUN9I || MACH_SUN8I_A83T same here > diff --git a/drivers/clk/sunxi/Makefile b/drivers/clk/sunxi/Makefile > index 3fd7901..38dfca8 100644 > --- a/drivers/clk/sunxi/Makefile > +++ b/drivers/clk/sunxi/Makefile > @@ -17,8 +17,8 @@ obj-y += clk-sun9i-core.o > obj-y += clk-sun9i-mmc.o > obj-y += clk-usb.o > > -obj-$(CONFIG_MACH_SUN9I) += clk-sun8i-apb0.o > -obj-$(CONFIG_MACH_SUN9I) += clk-sun9i-cpus.o > +obj-$(CONFIG_CLK_SUN8I_APB0) += clk-sun8i-apb0.o > +obj-$(CONFIG_CLK_SUN9I_CPUS) += clk-sun9i-cpus.o > > obj-$(CONFIG_MFD_SUN6I_PRCM) += \ > clk-sun6i-ar100.o clk-sun6i-apb0.o clk-sun6i-apb0-gates.o \ > -- > 1.9.1 >