Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750760AbcCEQ26 (ORCPT ); Sat, 5 Mar 2016 11:28:58 -0500 Received: from mail-qk0-f170.google.com ([209.85.220.170]:32953 "EHLO mail-qk0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750709AbcCEQ2u convert rfc822-to-8bit (ORCPT ); Sat, 5 Mar 2016 11:28:50 -0500 From: Michal Nazarewicz To: Felipe Ferreri Tonello , linux-usb@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Felipe Balbi , Clemens Ladisch Subject: Re: [PATCH 4/5] usb: gadget: f_midi: cleanups and typos fixes In-Reply-To: <17F55117-7DFB-4EE9-811C-7C1BAEA1D09C@felipetonello.com> Organization: http://mina86.com/ References: <1456947640-20673-1-git-send-email-eu@felipetonello.com> <1456947640-20673-5-git-send-email-eu@felipetonello.com> <17F55117-7DFB-4EE9-811C-7C1BAEA1D09C@felipetonello.com> User-Agent: Notmuch/0.19+53~g2e63a09 (http://notmuchmail.org) Emacs/25.1.50.1 (x86_64-unknown-linux-gnu) Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAJFBMVEWbfGlUPDDHgE57V0jUupKjgIObY0PLrom9mH4dFRK4gmjPs41MxjOgAAACP0lEQVQ4T23Sv2vbQBQHcBk1xE6WyALX107VUEgmn6+ouUwpEQQ6uRjttkWP4CkBg2M0BQLBdPFZYPsyFYo7qEtKDQ7on+t7+nF2Ux8ahD587717OmNYrOvycHsZ+o2r051wHTHysAvGb8ygvgu4QWT0sCmkgZCIEnlV2X8BtyraazFGDuxhmKSQJMlwHQ7v5MHSNxmz78rfElwAa3ieVD9e+hBhjaPDDG6NgFo2f4wBMNIo5YmRtF0RyDgFjJjlMIWbnuM4x9MMfABGTlN4qgIQB4A1DEyA1BHWtfeWNUMwiVJKoqh97KrkOO+qzgluVYLvFCUKAX73nONeBr7BGMdM6Sg0kuep03VywLaIzRiVr+GAzKlpQIsAFnWAG2e6DT5WmWDiudZMIc6hYrMOmeMQK9WX0B+/RfjzL9DI7Y9/Iayn29Ci0r2i4f9gMimMSZLCDMalgQGU5hnUtqAN0OGvEmO1Wnl0C0wWSCEHnuHBqmygxdxA8oWXwbipoc1EoNR9DqOpBpOJrnr0criQab9ZT4LL+wI+K7GBQH30CrhUruilgP9DRTrhVWZCiAyILP+wiuLeCKGTD6r/nc8LOJcAwR6IBTUs+7CASw3QFZ0MdA2PI3zNziH4ZKVhXCRMBjeZ1DWMekKwDCASwExy+NQ86TaykaDAFHO4aP48y4fIcDM5yOG8GcTLbOyp8A8azjJI93JFd1EA6yN8sSxMQJWoABqniRZVykYgRXErzrdqExAoUrRb0xfRp8p2A/4XmfilTtkDZ4cAAAAASUVORK5CYII= X-Face: -TR8(rDTHy/(xl?SfWd1|3:TTgDIatE^t'vop%*gVg[kn$t{EpK(P"VQ=~T2#ysNmJKN$"yTRLB4YQs$4{[.]Fc1)*O]3+XO^oXM>Q#b^ix,O)Zbn)q[y06$`e3?C)`CwR9y5riE=fv^X@x$y?D:XO6L&x4f-}}I4=VRNwiA^t1-ZrVK^07.Pi/57c_du'& X-PGP: 50751FF4 X-PGP-FP: AC1F 5F5C D418 88F8 CC84 5858 2060 4012 5075 1FF4 X-Hashcash: 1:20:160305:clemens@ladisch.de::CD1Kk/RqHSfnEP5v:00000000000000000000000000000000000000000000vw2 X-Hashcash: 1:20:160305:balbi@kernel.org::pUsDJG7cTqkAEUeJ:00+pY X-Hashcash: 1:20:160305:linux-usb@vger.kernel.org::0TQkRndeowDMJ90N:0000000000000000000000000000000000000XF+ X-Hashcash: 1:20:160305:linux-kernel@vger.kernel.org::gQxCdMAaphc98JWd:0000000000000000000000000000000001liW X-Hashcash: 1:20:160305:eu@felipetonello.com::JooxPnvHLJEMWkXi:000000000000000000000000000000000000000001e1V Date: Sat, 05 Mar 2016 11:28:45 -0500 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1246 Lines: 32 >> On Wed, Mar 02 2016, Felipe F. Tonello wrote: >>> @@ -16,7 +16,7 @@ >>> * Copyright (C) 2006 Thumtronics Pty Ltd. >>> * Ben Williamson >>> * >>> - * Licensed under the GPL-2 or later. >>> + * Licensed under the GPLv2. > On March 4, 2016 7:17:31 PM GMT+00:00, Michal Nazarewicz wrote: >> Any particular reason to do that? On Fri, Mar 04 2016, Felipe Ferreri Tonello wrote: > Because the kernel is v2 only and not later. Linux as a whole is GPLv2 only, but that doesn’t necessarily mean that parts of it cannot be dual licensed (or GPLv2+). It’s safer to leave copyright noticed clear unless you explicitly want your contribution be GPLv2 only which brings the whole file GPLv2 only. > I just tried to make this driver more consistent with the coding style > used across the kernel. That's it. Column alignment of field names or RHS of assignment operators is quite inconsistent already within drivers/usb/gadget/ which is why I’m concerned whether this is really helping. Anyway, I actually don’t care much, just adding my two rappen. -- Best regards ミハウ “????????????????86” ナザレヴイツ «If at first you don’t succeed, give up skydiving»