Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751124AbcCEW1P (ORCPT ); Sat, 5 Mar 2016 17:27:15 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:57946 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750801AbcCEW1A (ORCPT ); Sat, 5 Mar 2016 17:27:00 -0500 Date: Sat, 5 Mar 2016 14:26:59 -0800 From: Greg Kroah-Hartman To: Srinivas Kandagatla Cc: Andy Gross , Stephen Boyd , David Brown , Jiri Slaby , linux-arm-msm@vger.kernel.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] tty: msm_serial: remove static clk rate setting in probe Message-ID: <20160305222659.GA6557@kroah.com> References: <1456831373-14839-1-git-send-email-srinivas.kandagatla@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1456831373-14839-1-git-send-email-srinivas.kandagatla@linaro.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1629 Lines: 44 On Tue, Mar 01, 2016 at 11:22:53AM +0000, Srinivas Kandagatla wrote: > The issue with setting up a fixed clock rate at probe is that it would > overwrite the console rate set by the bootloader for its console device. > This would result in serial out corruption or missing log when we system > is booted with earlycon. This is not a issue if we boot system without > earlycon. > > This setup is ateast not required with the mainline driver. > > Originally the issue was noticed on DB410c which is based on APQ8016 > chipset. > > Without this patch the console log with earlycon would look like: > ... > [ 0.000000] RCU: Adjusting geometry for rcu_fanout_leaf=64, nr_cpu_ids=1 > [ 0.000000] NR_IRQS:64 nr_irqs:64 0 > ����+HH��0.699378] console [ttyMSM0] enabled > [ 0.699378] console [ttyMSM0] enabled > [ 0.702003] bootconsole [uart0] disabled > [ 0.702003] bootconsole [uart0] disabled > ... > > with this patch I can see all the skipped lines on the console > > Signed-off-by: Srinivas Kandagatla > --- > drivers/tty/serial/msm_serial.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/tty/serial/msm_serial.c b/drivers/tty/serial/msm_serial.c > index dcde955..0a31b3e 100644 > --- a/drivers/tty/serial/msm_serial.c > +++ b/drivers/tty/serial/msm_serial.c > @@ -1580,7 +1580,6 @@ static int msm_serial_probe(struct platform_device *pdev) > if (IS_ERR(msm_port->pclk)) > return PTR_ERR(msm_port->pclk); > > - clk_set_rate(msm_port->clk, 1843200); Delete the unneeded blank line as well please, when you resend this. thanks, greg k-h