Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751170AbcCEX57 (ORCPT ); Sat, 5 Mar 2016 18:57:59 -0500 Received: from mail-wm0-f65.google.com ([74.125.82.65]:33353 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750859AbcCEX5v (ORCPT ); Sat, 5 Mar 2016 18:57:51 -0500 User-Agent: K-9 Mail for Android In-Reply-To: References: <1456947640-20673-1-git-send-email-eu@felipetonello.com> <1456947640-20673-5-git-send-email-eu@felipetonello.com> <17F55117-7DFB-4EE9-811C-7C1BAEA1D09C@felipetonello.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Subject: Re: [PATCH 4/5] usb: gadget: f_midi: cleanups and typos fixes From: Felipe Ferreri Tonello Date: Sat, 05 Mar 2016 23:57:45 +0000 To: Michal Nazarewicz , linux-usb@vger.kernel.org CC: linux-kernel@vger.kernel.org, Felipe Balbi , Clemens Ladisch Message-ID: <2D03FBFE-F890-44C7-AFF1-C2166B2DC903@felipetonello.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1504 Lines: 39 Hi Michal, On March 5, 2016 4:28:45 PM GMT+00:00, Michal Nazarewicz wrote: >>> On Wed, Mar 02 2016, Felipe F. Tonello wrote: >>>> @@ -16,7 +16,7 @@ >>>> * Copyright (C) 2006 Thumtronics Pty Ltd. >>>> * Ben Williamson >>>> * >>>> - * Licensed under the GPL-2 or later. >>>> + * Licensed under the GPLv2. > >> On March 4, 2016 7:17:31 PM GMT+00:00, Michal Nazarewicz > wrote: >>> Any particular reason to do that? > >On Fri, Mar 04 2016, Felipe Ferreri Tonello wrote: >> Because the kernel is v2 only and not later. > >Linux as a whole is GPLv2 only, but that doesn’t necessarily mean that >parts of it cannot be dual licensed (or GPLv2+). It’s safer to leave >copyright noticed clear unless you explicitly want your contribution be >GPLv2 only which brings the whole file GPLv2 only. > >> I just tried to make this driver more consistent with the coding >style >> used across the kernel. That's it. > >Column alignment of field names or RHS of assignment operators is quite >inconsistent already within drivers/usb/gadget/ which is why I’m >concerned whether this is really helping. > >Anyway, I actually don’t care much, just adding my two rappen. Right, I am ok with Balbi completely ignoring this patch. But I prefer to have at least this driver consistent than nothing. Of course I'll remove the license change I made. Felipe -- Sent from my Android device with K-9 Mail. Please excuse my brevity.