Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751350AbcCFJJd (ORCPT ); Sun, 6 Mar 2016 04:09:33 -0500 Received: from spo001.leaseweb.nl ([83.149.101.17]:48791 "EHLO spo001.leaseweb.nl" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1751154AbcCFJJX (ORCPT ); Sun, 6 Mar 2016 04:09:23 -0500 Date: Sun, 6 Mar 2016 10:09:20 +0100 From: Wim Van Sebroeck To: Wolfram Sang Cc: linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Guenter Roeck , linux-watchdog@vger.kernel.org Subject: Re: [PATCH 5/6] watchdog: atlas7_wdt: test clock rate to avoid division by 0 Message-ID: <20160306090920.GA1333@spo001.leaseweb.nl> References: <1456958018-7849-1-git-send-email-wsa@the-dreams.de> <1456958018-7849-6-git-send-email-wsa@the-dreams.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1456958018-7849-6-git-send-email-wsa@the-dreams.de> User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1020 Lines: 39 Hi Wolfram, > From: Wolfram Sang > > The clk API may return 0 on clk_get_rate, so we should check the result before > using it as a divisor. > > Signed-off-by: Wolfram Sang > --- > > Should go individually via subsystem tree. > > drivers/watchdog/atlas7_wdt.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/watchdog/atlas7_wdt.c b/drivers/watchdog/atlas7_wdt.c > index df6d9242a31958..ed80734befae16 100644 > --- a/drivers/watchdog/atlas7_wdt.c > +++ b/drivers/watchdog/atlas7_wdt.c > @@ -154,6 +154,11 @@ static int atlas7_wdt_probe(struct platform_device *pdev) > writel(0, wdt->base + ATLAS7_WDT_CNT_CTRL); > > wdt->tick_rate = clk_get_rate(clk); > + if (!wdt->tick_rate) { > + ret = -EINVAL; > + goto err1; > + } > + > wdt->clk = clk; > atlas7_wdd.min_timeout = 1; > atlas7_wdd.max_timeout = UINT_MAX / wdt->tick_rate; > -- > 2.7.0 > Patch has been added to linux-watchdog-next. Kind regards, Wim.