Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751913AbcCFL6F (ORCPT ); Sun, 6 Mar 2016 06:58:05 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:33801 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751660AbcCFL5h (ORCPT ); Sun, 6 Mar 2016 06:57:37 -0500 Message-ID: In-Reply-To: <56D54BC2.70902@suse.de> References: <1456666367-11418-1-git-send-email-ygardi@codeaurora.org> <1456666367-11418-16-git-send-email-ygardi@codeaurora.org> <56D54BC2.70902@suse.de> Date: Sun, 6 Mar 2016 11:57:34 -0000 Subject: Re: [PATCH v5 15/15] scsi: ufs-qcom: set PA_Local_TX_LCC_Enable before link startup From: ygardi@codeaurora.org To: "Hannes Reinecke" Cc: "Yaniv Gardi" , james.bottomley@hansenpartnership.com, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, linux-arm-msm@vger.kernel.org, santoshsy@gmail.com, linux-scsi-owner@vger.kernel.org, "Vinayak Holikatti" , "James E.J. Bottomley" , "Martin K. Petersen" User-Agent: SquirrelMail/1.4.22-4.el6 MIME-Version: 1.0 Content-Type: text/plain;charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Priority: 3 (Normal) Importance: Normal Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1172 Lines: 38 > On 02/28/2016 09:32 PM, Yaniv Gardi wrote: >> Some UFS devices (and may be host) have issues if LCC is >> enabled. So we are setting PA_Local_TX_LCC_Enable to 0 >> before link startup which will make sure that both host >> and device TX LCC are disabled once link startup is >> completed. >> >> This change also: >> - enables the device ref clock before changing to HS mode >> and disables it if entered to PWM mode >> - adds printouts of testbus debug registers >> > Please make that in two patches; these issues are unrelated and will > just confuse users if one ever need to dig through the git log. > done. in V6 this patch will be divided into 3 patches. 1. LX_LCC 2. device ref clock 3. debug printouts thanks, Yaniv > Cheers, > > Hannes > -- > Dr. Hannes Reinecke zSeries & Storage > hare@suse.de +49 911 74053 688 > SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N?rnberg > GF: J. Hawn, J. Guild, F. Imend?rffer, HRB 16746 (AG N?rnberg) > -- > To unsubscribe from this list: send the line "unsubscribe linux-scsi" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >