Date: Sun, 6 Mar 2016 16:23:39 +0100
From: Sebastian Reichel <sre@kernel.org>
To: Pali =?iso-8859-1?Q?Roh=E1r?= <pali.rohar@gmail.com>
Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>,
        Jarkko Nikula <jarkko.nikula@bitmer.com>,
        Lars-Peter Clausen <lars@metafoo.de>, linux-kernel@vger.kernel.org,
        linux-omap@vger.kernel.org, Pavel Machek <pavel@ucw.cz>,
        Aaro Koskinen <aaro.koskinen@iki.fi>, Tony Lindgren <tony@atomide.com>,
        Nishanth Menon <nm@ti.com>,
        Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>, merlijn@wizzup.org
Subject: Re: Nokia N900 - audio TPA6130A2 problems
Message-ID: <20160306152339.GA428@earth>
References: <201507251228.27128@pali>
 <55BFB77C.6000208@bitmer.com>
 <55C0638F.30000@ti.com>
 <201601050034.12810@pali>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="cWoXeonUoKmBZSoM"
Content-Disposition: inline
In-Reply-To: <201601050034.12810@pali>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 3517
Lines: 86


--cWoXeonUoKmBZSoM
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi Pali,

On Tue, Jan 05, 2016 at 12:34:12AM +0100, Pali Roh=E1r wrote:
> On Tuesday 04 August 2015 09:02:39 Peter Ujfalusi wrote:
> > On 08/03/2015 09:48 PM, Jarkko Nikula wrote:
> > > It is well possible that some regression got introduced to
> > > TPA6130A2 I2C communication over the years without nobody than you
> > > now notices. We used to do QA back in Meego N900 days but that was
> > > pre 3.x kernels.
> >=20
> > No major changes has been done to the tpa driver during the past
> > years... I wanted to do some updates, like moving it to regmap, but
> > as you said, n900 is the only user (and n9) and I do not feel
> > comfortable to hack on a device where I do not have serial
> > console... And I'm using the n900 time to time also.
> >=20
> > >> So maybe something similar? Kernel expects that some PM or
> > >> regulator parts are initialized, but they are only sometimes?
> > >> Just speculation...
> > >=20
> > > I'm thinking the same. I could figure SCL could be stuck low if TPA
> > > or some other chip connected to the same I2C bus is without power
> > > and is pulling I2C signals down.
> >=20
> > What would happen with the SCL stuck on i2c.2 bus if you remove the
> > tpa driver from the kernel? If you remove the other drivers for the
> > devices on i2c.2?
>=20
> Hi Peter and Jarkko! Do you have some code samples for testing? Or=20
> something else which I can test? This problem is still reproducible on=20
> more N900 devices and I would like to see it fixed.

I have not seen your error with N900, but while working on N950 I
noticed similar problems when I added lp5523. I think the lp5523
reset routine locks up the omap i2c controller, since the lp5523
will stop responding in the middle of an ongoing communication:

static void lp55xx_reset_device(struct lp55xx_chip *chip)
{
	struct lp55xx_device_config *cfg =3D chip->cfg;
	u8 addr =3D cfg->reset.addr;
	u8 val  =3D cfg->reset.val;

	/* no error checking here because no ACK from the device after reset */
	lp55xx_write(chip, addr, val);
}

Since tpa6130a2 is on the same i2c bus, it would be affected by
this. You can check this by just commenting out the call to
lp55xx_reset_device() in the probe function, since it's not
needed on N900 (chip reset is done via enable gpio anyways).

I'm pretty sure, there were no bus lock problems when I added
lp5523 to N900 dts, so this having problems with this is probably
a regression in the omap-i2c driver.

-- Sebastian

--cWoXeonUoKmBZSoM
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCgAGBQJW3Et5AAoJENju1/PIO/qa82cQAJtMeWwC0OLHHsL9CYmZYKPC
KQFY8rFAZ76BR578okg+uGTBhM1C7DaYMuq1BQZJeenLOrH1YcKfa9eUrOgiWk94
fN7QKvbnZskHG/CAwsHXTyW0yi4HvcltN7gw3ar8/2eQBDpM4DXcwkYxj1eBihcI
QmfNsbI1pJsymLimeLYFjnxyc9BQq9F3AyXxvaoAoyWCCl+3eZzOeuSWvZ0/UM9z
t2OdtLzc4pEA+l0HSb+CHFvmdxJsOipnQJ4VDdWsQYXRP+491PurtwxoVL8C/PzD
Veu4O/oGSi7hO8zeMGuUhqckB7JltygCI6mjo9S7b9truH1NuY14wNMVJdn/AfI2
2W4j6yq/BuoiXm+/UHvOzZmSYRZKoxynaq09UOEcir3iY5o7H0l0YcegHqSKhbHU
RFJH8NPMZ4aQbG3LXHjZunZn0/VYsDUD4y1zWKwRbL0lqqOrizdhG7ebF83wbjCg
QTzMnRY0vZQic5NVJW5IMx15zuqZmncOT7gcC8jhoapFYlpLMM2CJvhfbi9Ii6dG
qSFVQ6sjMjefhzKoCmCT912tmRpVBGQQQ2jC6jQxvzVNNB+tGlw03Nkh/1bIv4Al
UFvnV8Qvg/P0Bu614IrCBJAZx2qxUUh6E0dDq1nUcNIZsgLuRf33inAE6wNSZRci
cjWO2OCZk1DP4K9XLejR
=ZQ4l
-----END PGP SIGNATURE-----

--cWoXeonUoKmBZSoM--