From: Fugang Duan <fugang.duan@nxp.com>
To: nick <xerofoify@gmail.com>, "davem@davemloft.net" <davem@davemloft.net>
CC: "b38611@freescale.com" <b38611@freescale.com>,
        "andrew@lunn.ch" <andrew@lunn.ch>,
        "fabio.estevam@freescale.com" <fabio.estevam@freescale.com>,
        "l.stach@pengutronix.de" <l.stach@pengutronix.de>,
        "rmk+kernel@arm.linux.org.uk" <rmk+kernel@arm.linux.org.uk>,
        "tremyfr@gmail.com" <tremyfr@gmail.com>,
        "johannes@sipsolutions.net" <johannes@sipsolutions.net>,
        "u.kleine-koenig@pengutronix.de" <u.kleine-koenig@pengutronix.de>,
        "haokexin@gmail.com" <haokexin@gmail.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH RESEND] net:fec:Fix error checking in the function
 fec_enet_init
Thread-Topic: [PATCH RESEND] net:fec:Fix error checking in the function
 fec_enet_init
Thread-Index: AQHRdlCAN78MHaMffkSxhGMRCcWvmZ9LiWgAgABAXQCAAM6KcA==
Date: Sun, 6 Mar 2016 16:10:14 +0000
Message-ID: <VI1PR0401MB18556DB43CA611545DB37C21FFB00@VI1PR0401MB1855.eurprd04.prod.outlook.com>
References: <1457121614-9360-1-git-send-email-xerofoify@gmail.com>
 <HE1PR0401MB184955CA43469AEE38664467FFB00@HE1PR0401MB1849.eurprd04.prod.outlook.com>
 <56DBA8D0.5090906@gmail.com>
In-Reply-To: <56DBA8D0.5090906@gmail.com>
Accept-Language: zh-CN, en-US
Content-Language: en-US
spamdiagnosticoutput: 1:23
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Mar 2016 16:10:15.0496
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB1854
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u26GAVnw009216
Content-Length: 2639
Lines: 76

From: nick <xerofoify@gmail.com> Sent: Sunday, March 06, 2016 11:50 AM
> To: Fugang Duan <fugang.duan@nxp.com>; davem@davemloft.net
> Cc: b38611@freescale.com; andrew@lunn.ch; fabio.estevam@freescale.com;
> l.stach@pengutronix.de; rmk+kernel@arm.linux.org.uk; tremyfr@gmail.com;
> johannes@sipsolutions.net; u.kleine-koenig@pengutronix.de;
> haokexin@gmail.com; netdev@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH RESEND] net:fec:Fix error checking in the function
> fec_enet_init
> 
> 
> 
> On 2016-03-05 07:00 PM, Fugang Duan wrote:
> > From: Nicholas Krause <xerofoify@gmail.com> Sent: Saturday, March 05,
> > 2016 4:00 AM
> >> To: davem@davemloft.net
> >> Cc: b38611@freescale.com; andrew@lunn.ch;
> >> fabio.estevam@freescale.com; l.stach@pengutronix.de;
> >> rmk+kernel@arm.linux.org.uk; tremyfr@gmail.com;
> >> johannes@sipsolutions.net; u.kleine-koenig@pengutronix.de;
> >> haokexin@gmail.com; netdev@vger.kernel.org;
> >> linux-kernel@vger.kernel.org
> >> Subject: [PATCH RESEND] net:fec:Fix error checking in the function
> >> fec_enet_init
> >>
> >> This fixes error checking in the function fec_enet_init to properly
> >> check if the internal call to the function fec_enet_alloc_queue fails
> >> and if so immediately return the error code to the caller for it to handle it's
> own intended error paths.
> >>
> >> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> >> ---
> >>  drivers/net/ethernet/freescale/fec_main.c | 5 ++++-
> >>  1 file changed, 4 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/net/ethernet/freescale/fec_main.c
> >> b/drivers/net/ethernet/freescale/fec_main.c
> >> index b349e6f..18c625f 100644
> >> --- a/drivers/net/ethernet/freescale/fec_main.c
> >> +++ b/drivers/net/ethernet/freescale/fec_main.c
> >> @@ -3123,6 +3123,7 @@ static int fec_enet_init(struct net_device *ndev)
> >>  	dma_addr_t bd_dma;
> >>  	int bd_size;
> >>  	unsigned int i;
> >> +	int ret;
> >>
> >>  #if defined(CONFIG_ARM)
> >>  	fep->rx_align = 0xf;
> >> @@ -3132,7 +3133,9 @@ static int fec_enet_init(struct net_device *ndev)
> >>  	fep->tx_align = 0x3;
> >>  #endif
> >>
> >> -	fec_enet_alloc_queue(ndev);
> >> +	ret = fec_enet_alloc_queue(ndev);
> >> +	if (ret)
> >> +		return ret;
> >>
> >>  	if (fep->bufdesc_ex)
> >>  		fep->bufdesc_size = sizeof(struct bufdesc_ex);
> >> --
> >> 2.1.4
> > Thanks.
> >
> > Acked-by: Fugang Duan <Fugang.duan@nxp.com>
> >
> Fugang,
> I have a few other patches for freescale ethernet drivers lying around. Would
> you like me to resend them or are you just taking this one patch?
> Cheers,
> Nick

Hi Nick,

Pls resend them, thanks.

Regards,
Andy