Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751897AbcCGBVO (ORCPT ); Sun, 6 Mar 2016 20:21:14 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:47430 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751236AbcCGBVJ (ORCPT ); Sun, 6 Mar 2016 20:21:09 -0500 Date: Sun, 6 Mar 2016 17:21:08 -0800 From: Greg KH To: Saiyam Doshi Cc: arve@android.com, riandrews@android.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] staging: android: Fixed coding style issues reported by checkpatch Message-ID: <20160307012108.GA1642@kroah.com> References: <1457292633-3058-1-git-send-email-saiyamdoshi.in@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1457292633-3058-1-git-send-email-saiyamdoshi.in@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 618 Lines: 17 On Mon, Mar 07, 2016 at 01:00:33AM +0530, Saiyam Doshi wrote: > List of modified files with comment, > lowmemorykiller.c: Added blank line after array declaration > sync.h: Added comment for spinlock_t definition, > Fixed parentheses alignment in function declaration > sync_debug.c: Removed unnecessary braces for single statement block > timed_gpio.c: Added comment for spinlock_t definition You need to do only one thing per patch, please split this up into multiple patches. Also verify that these are all really needed, please always work against linux-next, not Linus's kernel tree. thanks, greg k-h