Date: Mon, 7 Mar 2016 02:16:39 +0000
From: Al Viro <viro@ZenIV.linux.org.uk>
To: "Yan, Zheng" <zyan@redhat.com>
Cc: Sage Weil <sweil@redhat.com>, linux-kernel@vger.kernel.org,
        linux-fsdevel@vger.kernel.org, ceph-devel@vger.kernel.org
Subject: Re: [ceph] what's going on with d_rehash() in splice_dentry()?
Message-ID: <20160307021639.GR17997@ZenIV.linux.org.uk>
References: <20160226174250.GA17997@ZenIV.linux.org.uk>
 <alpine.DEB.2.11.1603010946290.24758@cpach.fuggernut.com>
 <B17B70FF-4B76-4593-9D96-F0298F83AEB3@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <B17B70FF-4B76-4593-9D96-F0298F83AEB3@redhat.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2257
Lines: 45

On Wed, Mar 02, 2016 at 11:00:01AM +0800, Yan, Zheng wrote:

> > This code dates back to when Ceph was originally upstreamed, so the 
> > history is murky, but I expect at that point I wanted to avoid hashing in 
> > the no-lease case.  But I don't think it matters.  We should just remove 
> > the prehash argument from splice_dentry entirely.
> > 
> > Zheng, does that sound right?
> 
> Yes. I think we can remove the d_rehash(dn) call and rehash parameter.

Another question in the same general area:
                /* null dentry? */
                if (!rinfo->head->is_target) {
                        dout("fill_trace null dentry\n");
                        if (d_really_is_positive(dn)) {
                                ceph_dir_clear_ordered(dir);
                                dout("d_delete %p\n", dn);
                                d_delete(dn);
                        } else {
                                dout("d_instantiate %p NULL\n", dn);
                                d_instantiate(dn, NULL);
                                if (have_lease && d_unhashed(dn))
                                        d_rehash(dn);
                                update_dentry_lease(dn, rinfo->dlease,
                                                    session,
                                                    req->r_request_started);
                        }
                        goto done;
                }
What's that d_instantiate() about?  We have just checked that it's
negative; what's the point of setting ->d_inode to NULL again?  Would it
be OK if we just do
			} else {
				if (have_lease && d_unhashed(dn))
					d_add(dn, NULL);
                                update_dentry_lease(dn, rinfo->dlease,
                                                    session,
                                                    req->r_request_started);
                        }
in there?  As an aside, tracking back to the originating fs method is
painful as hell ;-/  I _think_ that rehash can be hit during ->lookup()
returning a negative, but I wouldn't bet a dime on it not happening from
other methods...  AFAICS, the change should be OK regardless of what
it's been called from, but... _ouch_.  Is is documented anywhere public?