From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/4] arm64: dts: Add dts files for LG Electronics's lg1312 SoC
Date: Mon, 7 Mar 2016 05:26:39 +0100
User-Agent: KMail/1.12.2 (Linux/3.19.0-54-generic; KDE/4.3.2; x86_64; ; )
Cc: Chanho Min <chanho.min@lge.com>, arm@kernel.org,
        Catalin Marinas <catalin.marinas@arm.com>,
        Gunho Lee <gunho.lee@lge.com>, Will Deacon <will.deacon@arm.com>,
        linux-kernel@vger.kernel.org, Jongsung Kim <neidhard.kim@lge.com>
References: <1457323800-26904-1-git-send-email-chanho.min@lge.com> <1457323800-26904-4-git-send-email-chanho.min@lge.com>
In-Reply-To: <1457323800-26904-4-git-send-email-chanho.min@lge.com>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <201603070526.40020.arnd@arndb.de>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 539
Lines: 20

On Monday 07 March 2016, Chanho Min wrote:
> +
> +       chosen {
> +               bootargs = "root=/dev/nfs ip=dhcp";
> +       };

Can you add a stdout-path property as well, to make the console work?

Please also include an aliases node in the .dts file.

> +
> +#include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/interrupt-controller/arm-gic.h>
> +
> +#define ARMV8_TIMER_IRQ_TYPE	(GIC_CPU_MASK_RAW(0x0f) | IRQ_TYPE_LEVEL_LOW)

I would leave out the macro here and instead just open-code this in the place it
is used.

	Arnd