Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752386AbcCGHgJ (ORCPT ); Mon, 7 Mar 2016 02:36:09 -0500 Received: from mga01.intel.com ([192.55.52.88]:57591 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752169AbcCGHgE (ORCPT ); Mon, 7 Mar 2016 02:36:04 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,550,1449561600"; d="asc'?scan'208";a="903586515" From: Felipe Balbi To: Felipe Ferreri Tonello , Michal Nazarewicz , linux-usb@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Clemens Ladisch Subject: Re: [PATCH 4/5] usb: gadget: f_midi: cleanups and typos fixes In-Reply-To: <2D03FBFE-F890-44C7-AFF1-C2166B2DC903@felipetonello.com> References: <1456947640-20673-1-git-send-email-eu@felipetonello.com> <1456947640-20673-5-git-send-email-eu@felipetonello.com> <17F55117-7DFB-4EE9-811C-7C1BAEA1D09C@felipetonello.com> <2D03FBFE-F890-44C7-AFF1-C2166B2DC903@felipetonello.com> User-Agent: Notmuch/0.21 (http://notmuchmail.org) Emacs/25.0.90.3 (x86_64-pc-linux-gnu) Date: Mon, 07 Mar 2016 09:35:16 +0200 Message-ID: <87bn6qkaff.fsf@intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2607 Lines: 75 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi, Felipe Ferreri Tonello writes: > [ text/plain ] > Hi Michal,=20 > > On March 5, 2016 4:28:45 PM GMT+00:00, Michal Nazarewicz wrote: >>>> On Wed, Mar 02 2016, Felipe F. Tonello wrote: >>>>> @@ -16,7 +16,7 @@ >>>>> * Copyright (C) 2006 Thumtronics Pty Ltd. >>>>> * Ben Williamson >>>>> * >>>>> - * Licensed under the GPL-2 or later. >>>>> + * Licensed under the GPLv2. >> >>> On March 4, 2016 7:17:31 PM GMT+00:00, Michal Nazarewicz >> wrote: >>>> Any particular reason to do that? >> >>On Fri, Mar 04 2016, Felipe Ferreri Tonello wrote: >>> Because the kernel is v2 only and not later.=20 >> >>Linux as a whole is GPLv2 only, but that doesn=E2=80=99t necessarily mean= that >>parts of it cannot be dual licensed (or GPLv2+). It=E2=80=99s safer to l= eave >>copyright noticed clear unless you explicitly want your contribution be >>GPLv2 only which brings the whole file GPLv2 only. >> >>> I just tried to make this driver more consistent with the coding >>style >>> used across the kernel. That's it. >> >>Column alignment of field names or RHS of assignment operators is quite >>inconsistent already within drivers/usb/gadget/ which is why I=E2=80=99m >>concerned whether this is really helping. >> >>Anyway, I actually don=E2=80=99t care much, just adding my two rappen. > > Right, I am ok with Balbi completely ignoring this patch. But I prefer > to have at least this driver consistent than nothing. Of course I'll > remove the license change I made. consistent in what way ? =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJW3S80AAoJEIaOsuA1yqRE/o4P/Ati/pTzd7DYEtcHainQiARR b/eqNvd0hyyPIKcfEwt1aD6kZTLTydv8yOKxrC2NUPWt1gZaSKH6hIQavKwkAPIy +9fn294eqvIRGhMz9lbSe1UvtW5vV0/qucx9SD2cHEnkC3MSo1AhZnG7cYqCWYDe OJ+X4XOjcA9gi+vPrBWEgTqlbibvb7ASoZ4GuA8PmbVjEuhoGs9lqJWnSxRPsydH pVRJ8NnX7L4KI4ZsxdsNPwhFLAsMMaSESROkusHWBUfA9+C+PCmmS035fcMpAGWZ UUpQ1AQbJmnEiL1dUvQdCw9xt731b24R5OgkcaPQlE/TJ1ZnzvZ8UYmHXwML+tjC Je5sYw0pvmoXCi8aL1VWA4cNel+BwTTrnVFUoFdNrmH5RsdVp+TS/0q/UoISS6iX 4yWzX8+QKVMIAmSl0TseTv1XNImuR5BkSnFyIbwN7cy9Xfhqde3zDMsiVjn/6W64 cv/Ko7cAEiCgkNtn8nYp+gUhMqm58Kd+ebHtL1iiasUELNF/89Z2JZVpCyj3sLcm KWzhhD1hLyKsf/lzm9/hNZiqdSDfVRMjhvhKeUMrvbaUGiwzA3WQ7NNFDcJzKTwh icK4MXfJKlWlJyjSizoKJXbpF48leGYl5tk8NIChLA4e8f6gH/2R4S7GsHnafRjm fQe91nF1FUR21UmKzag/ =jnm2 -----END PGP SIGNATURE----- --=-=-=--