Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752560AbcCGKtl (ORCPT ); Mon, 7 Mar 2016 05:49:41 -0500 Received: from mail-oi0-f65.google.com ([209.85.218.65]:32933 "EHLO mail-oi0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752300AbcCGKtc (ORCPT ); Mon, 7 Mar 2016 05:49:32 -0500 MIME-Version: 1.0 X-Originating-IP: [217.173.44.24] In-Reply-To: <1444419297-16232-1-git-send-email-lk4d4@docker.com> References: <1444419297-16232-1-git-send-email-lk4d4@docker.com> Date: Mon, 7 Mar 2016 11:49:31 +0100 Message-ID: Subject: Re: [PATCH 0/2] Fix hardlinks in overlay From: Miklos Szeredi To: Alexander Morozov Cc: LKML , Alexander Morozov , "linux-unionfs@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1068 Lines: 22 On Fri, Oct 9, 2015 at 9:34 PM, Alexander Morozov wrote: > There were reports that overlay doesn't work very well with unix-sockets. > In particular you can't access unix-socket through hardlink on overlay fs. > Problem is that overlay creates different inodes for hardlinks and code in > net/unix/af_unix.c relies on inodes for unix-socket lookup. I think this > affects any code which relies on inodes from kern_path. There is helper > d_backing_inode, which I think supposed to get inodes from underlying fs > (for example ext4), but in current implementation it does nothing. These > patches made on top of v4.3-rc4 of main linux tree (master is broken for my > ubuntu VM), but I tested that they applying on master and there was no > changes to overlay since v4.3-rc4. > > Alexander Morozov (2): > fs/overlay: move update and instantiate dentry code to function > fs/overlay: use same inodes for hardlinks Problem is with lookup: how do we go from backing dentry to overlayfs dentry so the inode can be shared? Thanks, Miklos