From: =?utf-8?B?5rKz5ZCI6Iux5a6PIC8gS0FXQUnvvIxISURFSElSTw==?= 
	<hidehiro.kawai.ez@hitachi.com>
To: "'Borislav Petkov'" <bp@alien8.de>
CC: Andrew Morton <akpm@linux-foundation.org>,
        Thomas Mingarelli <thomas.mingarelli@hpe.com>,
        Wim Van Sebroeck <wim@iguana.be>, Corey Minyard <minyard@acm.org>,
        Javi Merino <javi.merino@arm.com>, Michal Hocko <mhocko@suse.com>,
        "linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>,
        "Steven Rostedt (Red Hat)" <rostedt@goodmis.org>,
        Rasmus Villemoes <linux@rasmusvillemoes.dk>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Michal Nazarewicz" <mina86@mina86.com>,
        Michal Hocko <mhocko@kernel.org>,
        "Vitaly Kuznetsov" <vkuznets@redhat.com>,
        HATAYAMA Daisuke <d.hatayama@jp.fujitsu.com>,
        Gobinda Charan Maji <gobinda.cemk07@gmail.com>,
        Tejun Heo <tj@kernel.org>, Nicolas Iooss <nicolas.iooss_linux@m4x.org>,
        "openipmi-developer@lists.sourceforge.net" 
	<openipmi-developer@lists.sourceforge.net>,
        Thomas Gleixner <tglx@linutronix.de>,
        Guenter Roeck <linux@roeck-us.net>
Subject: RE: [v3 PATCH 1/3] panic: Change nmi_panic from macro to function
Thread-Topic: [v3 PATCH 1/3] panic: Change nmi_panic from macro to function
Thread-Index: AQHRdTyg7BcvK4MlLUG2rBhSPWgBxJ9HHAUAgAa1AgA=
Date: Mon, 7 Mar 2016 10:53:51 +0000
Message-ID: <04EAB7311EE43145B2D3536183D1A84454B18988@GSjpTKYDCembx31.service.hitachi.net>
References: <20160303105741.4587.49047.stgit@softrs>
 <20160303105744.4587.1001.stgit@softrs> <20160303131458.GD24621@pd.tnic>
In-Reply-To: <20160303131458.GD24621@pd.tnic>
Accept-Language: ja-JP, en-US
Content-Language: ja-JP
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Content-Transfer-Encoding: 8bit
Content-Length: 1661
Lines: 48

> From: Borislav Petkov [mailto:bp@alien8.de]
> On Thu, Mar 03, 2016 at 07:57:44PM +0900, Hidehiro Kawai wrote:
> > Change nmi_panic() macro to a normal function for the portability.
> 
> portability?

I wanted to say encapsulating things into a function makes modules
only have to know about the function. Modules don't need to know
all things in the macro.  But I thought again, and `portability'
was not appropriate.

However, this patch set has been queued into -mm now.  So I'll
leave this if not necessary.

Regards,
Hidehiro Kawai

> > Also, export it for modules.
> >
> > Changes since v2:
> > - Make nmi_panic receive a single string instead of printf style args
> >
> > Signed-off-by: Hidehiro Kawai <hidehiro.kawai.ez@hitachi.com>
> > Cc: Andrew Morton <akpm@linux-foundation.org>
> > Cc: Borislav Petkov <bp@suse.de>
> > Cc: Michal Nazarewicz <mina86@mina86.com>
> > Cc: Michal Hocko <mhocko@suse.com>
> > Cc: Rasmus Villemoes <linux@rasmusvillemoes.dk>
> > Cc: Nicolas Iooss <nicolas.iooss_linux@m4x.org>
> > Cc: Javi Merino <javi.merino@arm.com>
> > Cc: Gobinda Charan Maji <gobinda.cemk07@gmail.com>
> > Cc: "Steven Rostedt (Red Hat)" <rostedt@goodmis.org>
> > Cc: Thomas Gleixner <tglx@linutronix.de>
> > Cc: Vitaly Kuznetsov <vkuznets@redhat.com>
> > Cc: HATAYAMA Daisuke <d.hatayama@jp.fujitsu.com>
> > Cc: Tejun Heo <tj@kernel.org>
> > ---
> >  include/linux/kernel.h |   21 +--------------------
> >  kernel/panic.c         |   20 ++++++++++++++++++++
> >  2 files changed, 21 insertions(+), 20 deletions(-)
> 
> Acked-by: Borislav Petkov <bp@suse.de>
> 
> --
> Regards/Gruss,
>     Boris.
> 
> ECO tip #101: Trim your mails when you reply.