Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752718AbcCGLHj (ORCPT <rfc822;w@1wt.eu>);
	Mon, 7 Mar 2016 06:07:39 -0500
Received: from mail9.hitachi.co.jp ([133.145.228.44]:47769 "EHLO
	mail9.hitachi.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752249AbcCGLHe (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 7 Mar 2016 06:07:34 -0500
From: =?utf-8?B?5rKz5ZCI6Iux5a6PIC8gS0FXQUnvvIxISURFSElSTw==?= 
	<hidehiro.kawai.ez@hitachi.com>
To: =?utf-8?B?5rKz5ZCI6Iux5a6PIC8gS0FXQUnvvIxISURFSElSTw==?= 
	<hidehiro.kawai.ez@hitachi.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Thomas Mingarelli <thomas.mingarelli@hpe.com>,
        Wim Van Sebroeck <wim@iguana.be>, Corey Minyard <minyard@acm.org>
CC: "linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Michal Hocko <mhocko@kernel.org>, Borislav Petkov <bp@alien8.de>,
        "openipmi-developer@lists.sourceforge.net" 
	<openipmi-developer@lists.sourceforge.net>,
        Guenter Roeck <linux@roeck-us.net>
Subject: RE: [Openipmi-developer] [v3 PATCH 3/3] hpwdt: Use nmi_panic()
 when kernel panics in NMI handler
Thread-Topic: [!][Openipmi-developer] [v3 PATCH 3/3] hpwdt: Use nmi_panic()
 when kernel panics in NMI handler
Thread-Index: AQHRdTxjAai/AxHtdEmm3m7cY6Y1RZ9N1ePA
Date: Mon, 7 Mar 2016 11:07:30 +0000
Message-ID: <04EAB7311EE43145B2D3536183D1A84454B189CD@GSjpTKYDCembx31.service.hitachi.net>
References: <20160303105741.4587.49047.stgit@softrs>
 <20160303105748.4587.70794.stgit@softrs>
In-Reply-To: <20160303105748.4587.70794.stgit@softrs>
Accept-Language: ja-JP, en-US
Content-Language: ja-JP
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.198.219.50]
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u27B7hEE012807
Content-Length: 1476
Lines: 39

> From: Phil Pokorny [mailto:ppokorny@penguincomputing.com]
> 
> While you are in drivers/watchdog/hpwdt.c replacing panic() with
> nmi_panic() can you also fix a few more of the broken strings?  The
> Linux style guide specfiically says NOT to break strings that are user
> visible because it breaks "grep".  So:

Ahh, yes.  I should have fixed this as well as the former case.
But this patch set has already been queued into -mm tree, so
I'll leave this patch if the fix is not important.

Regards,
Hidehiro Kawai

> 
> -       panic("An NMI occurred. Depending on your system the reason "
> +       nmi_panic(regs, "An NMI occurred. Depending on your system the reason "
>                 "for the NMI is logged in any one of the following "
>                 "resources:\n"
>                 "1. Integrated Management Log (IML)\n"
> 
> Should probably be:
> 
> -       panic("An NMI occurred. Depending on your system the reason "
> -                "for the NMI is logged in any one of the following "
> -                "resources:\n"
> +       nmi_panic(regs, "An NMI occurred. Depending on your system the
> reason for the NMI is logged in any one of the following resources:\n"
>                 "1. Integrated Management Log (IML)\n"
> 
> So it's okay to break on "\n", but not in the middle of a line.
> 
> --
> Philip Pokorny, RHCE
> Chief Technology Officer
> PENGUIN COMPUTING, Inc
> www.penguincomputing.com
> 
> Changing the world through technical innovation