Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752750AbcCGM2P (ORCPT ); Mon, 7 Mar 2016 07:28:15 -0500 Received: from mga14.intel.com ([192.55.52.115]:33187 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752704AbcCGM2E (ORCPT ); Mon, 7 Mar 2016 07:28:04 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,551,1449561600"; d="scan'208";a="903835917" From: "Zhang, Rui" To: Wei Ni , "thierry.reding@gmail.com" , "mikko.perttunen@kapsi.fi" , Eduardo Valentin CC: Matt Longnecker , "swarren@wwwdotorg.org" , "linux-tegra@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH] thermal: tegra_soctherm: fix sign bit of temperature Thread-Topic: [PATCH] thermal: tegra_soctherm: fix sign bit of temperature Thread-Index: AQHRctbYzsKl6qd4TEm6RJdAkTFqsJ9FQeAAgAET+4CABtRXAIAAjYPw//+AcoCAALsQoA== Date: Mon, 7 Mar 2016 12:27:01 +0000 Message-ID: <744357E9AAD1214791ACBA4B0B9092633A972237@SHSMSX101.ccr.corp.intel.com> References: <1456739480-3304-1-git-send-email-wni@nvidia.com> <56D698FE.7070706@nvidia.com> <56D78081.6050106@nvidia.com> <56DD3B1E.4030805@nvidia.com> <744357E9AAD1214791ACBA4B0B9092633A9721DE@SHSMSX101.ccr.corp.intel.com> <56DD46D3.3060708@nvidia.com> In-Reply-To: <56DD46D3.3060708@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u27CSV3s013175 Content-Length: 2382 Lines: 72 Oh, BTW, you need to CC linux-pm@vger.kernel.org as well, so that we can see your patch via patchwork. Please resend patch V2 to linux-pm@vger.kernel.org. Thanks, rui > -----Original Message----- > From: Wei Ni [mailto:wni@nvidia.com] > Sent: Monday, March 07, 2016 5:16 PM > To: Zhang, Rui ; thierry.reding@gmail.com; > mikko.perttunen@kapsi.fi; Eduardo Valentin > Cc: Matt Longnecker ; swarren@wwwdotorg.org; > linux-tegra@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH] thermal: tegra_soctherm: fix sign bit of temperature > Importance: High > > > > On 2016年03月07日 16:55, Zhang, Rui wrote: > > For the soc thermal driver changes, you'd better cc Eduardo at the same > time so that he can include this in his soc-thermal pull request. > > Surely I can queue this for 4.6 if Eduardo miss this. > > Thanks for your help. > > BTW, please add: > Reviewed-by: Matt Longnecker > > Or I need to send v2 patch to add it? > > Thanks. > Wei. > > > > > Thanks, > > rui > > > >> -----Original Message----- > >> From: Wei Ni [mailto:wni@nvidia.com] > >> Sent: Monday, March 07, 2016 4:26 PM > >> To: thierry.reding@gmail.com; Zhang, Rui ; > >> mikko.perttunen@kapsi.fi > >> Cc: Matt Longnecker ; > swarren@wwwdotorg.org; > >> linux-tegra@vger.kernel.org; linux-kernel@vger.kernel.org > >> Subject: Re: [PATCH] thermal: tegra_soctherm: fix sign bit of > >> temperature > >> Importance: High > >> > >> Hi, Rui and Thierry > >> Could you please take a look at this patch? > >> > >> Thanks. > >> Wei. > >> > >> On 2016年03月03日 08:08, Matt Longnecker wrote: > >>> > >>> > >>> On 03/01/2016 11:40 PM, Wei Ni wrote: > >>>>> diff --git a/drivers/thermal/tegra_soctherm.c > >> b/drivers/thermal/tegra_soctherm.c > >>>>> index 74ea5765938b..136975220c92 100644 > >>>>> --- a/drivers/thermal/tegra_soctherm.c > >>>>> +++ b/drivers/thermal/tegra_soctherm.c > >>>>> @@ -57,7 +57,7 @@ > >>>>> #define READBACK_VALUE_MASK 0xff00 > >>>>> #define READBACK_VALUE_SHIFT 8 > >>>>> #define READBACK_ADD_HALF BIT(7) > >>>>> -#define READBACK_NEGATE BIT(1) > >>>>> +#define READBACK_NEGATE BIT(0) > >>> I confirm that this change is technically correct. It fixes a bug.