Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752641AbcCGNTY (ORCPT ); Mon, 7 Mar 2016 08:19:24 -0500 Received: from mail-lb0-f173.google.com ([209.85.217.173]:33282 "EHLO mail-lb0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751146AbcCGNTP (ORCPT ); Mon, 7 Mar 2016 08:19:15 -0500 MIME-Version: 1.0 In-Reply-To: <1457319045-25434-1-git-send-email-yu.c.chen@intel.com> References: <1457319045-25434-1-git-send-email-yu.c.chen@intel.com> Date: Mon, 7 Mar 2016 14:19:13 +0100 X-Google-Sender-Auth: D1hS8qvKzJt1uB8VqUV4KMc0f04 Message-ID: Subject: Re: [PATCH][RFC v3] ACPI / PM: Fix poweroff issue on HW-full platforms without _S5 From: "Rafael J. Wysocki" To: Chen Yu Cc: ACPI Devel Maling List , x86@kernel.org, linux-efi@vger.kernel.org, Linux Kernel Mailing List , "linux-pm@vger.kernel.org" , "Rafael J. Wysocki" , Len Brown , Matt Fleming , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Zhang Rui Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1859 Lines: 47 On Mon, Mar 7, 2016 at 3:50 AM, Chen Yu wrote: > The problem is Linux registers pm_power_off = efi_power_off > only if we are in hardware reduced mode. Actually, what we also > want is to do this when ACPI S5 is simply not supported on > non-legacy platforms. That should handle both the HW reduced mode, > and the HW-full mode where the DSDT fails to supply an _S5 object. > > This patch fixes this issue by introducing a new flag acpi_no_s5 which > indicates the non-existence of _S5. The initial state of acpi_no_s5 is > false and probed in acpi_sleep_init, then we'll later see the updated > value in efi_poweroff_required, according to which we can set pm_power_off > to efi_power_off in efi_shutdown_init, if no other pm_power_off available. > > Suggested-by: Len Brown > Signed-off-by: Chen Yu > --- > v3: > - Only assign pm_power_off to efi_power_off when there are no > other pm_power_off registered at that time, in case other > commponents would like to customize their own implementation. > --- > v2: > - Convert the acpi_no_s5 to a global bool variable in sleep.c and > add a declaration to include/linux/acpi.h. > --- > arch/x86/platform/efi/quirks.c | 2 +- > drivers/acpi/sleep.c | 8 ++++++++ > include/linux/acpi.h | 1 + > 3 files changed, 10 insertions(+), 1 deletion(-) > > diff --git a/arch/x86/platform/efi/quirks.c b/arch/x86/platform/efi/quirks.c > index 2d66db8..0d4186b 100644 > --- a/arch/x86/platform/efi/quirks.c > +++ b/arch/x86/platform/efi/quirks.c > @@ -295,5 +295,5 @@ bool efi_reboot_required(void) > > bool efi_poweroff_required(void) > { > - return !!acpi_gbl_reduced_hardware; > + return acpi_gbl_reduced_hardware || (acpi_no_s5 && !pm_power_off); What if CONFIG_ACPI is not set here? > } Thanks, Rafael