Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753258AbcCGPgl (ORCPT ); Mon, 7 Mar 2016 10:36:41 -0500 Received: from mx1.redhat.com ([209.132.183.28]:43502 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751146AbcCGPge (ORCPT ); Mon, 7 Mar 2016 10:36:34 -0500 Subject: Re: [PART1 RFC v2 06/10] svm: Add interrupt injection via AVIC To: Suravee Suthikulpanit , rkrcmar@redhat.com, joro@8bytes.org, bp@alien8.de, gleb@kernel.org, alex.williamson@redhat.com References: <1457124368-2025-1-git-send-email-Suravee.Suthikulpanit@amd.com> <1457124368-2025-7-git-send-email-Suravee.Suthikulpanit@amd.com> Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, wei@redhat.com, sherry.hurwitz@amd.com From: Paolo Bonzini Message-ID: <56DD9FF5.7010201@redhat.com> Date: Mon, 7 Mar 2016 16:36:21 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <1457124368-2025-7-git-send-email-Suravee.Suthikulpanit@amd.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 546 Lines: 23 On 04/03/2016 21:46, Suravee Suthikulpanit wrote: > +static void svm_deliver_avic_intr(struct kvm_vcpu *vcpu, int vec) > +{ > + struct vcpu_svm *svm = to_svm(vcpu); > + > + kvm_lapic_set_vector(vec, avic_get_bk_page_entry(svm, APIC_IRR)); > + > + if (vcpu->mode == IN_GUEST_MODE) { > + wrmsrl(SVM_AVIC_DOORBELL, > + __default_cpu_present_to_apicid(vcpu->cpu)); > + } else { > + kvm_vcpu_kick(vcpu); > + } You also need to add kvm_make_request(KVM_REQ_EVENT, vcpu); before the "if", similar to vmx_deliver_posted_interrupt. Paolo