Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753301AbcCGPxd (ORCPT <rfc822;w@1wt.eu>);
	Mon, 7 Mar 2016 10:53:33 -0500
Received: from mga03.intel.com ([134.134.136.65]:13255 "EHLO mga03.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752848AbcCGPxY (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 7 Mar 2016 10:53:24 -0500
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.22,552,1449561600"; 
   d="scan'208";a="903990570"
From: "Chen, Yu C" <yu.c.chen@intel.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
CC: ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
        "x86@kernel.org" <x86@kernel.org>,
        "linux-efi@vger.kernel.org" <linux-efi@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
        "Rafael J. Wysocki" <rjw@rjwysocki.net>, Len Brown <lenb@kernel.org>,
        Matt Fleming <matt@codeblueprint.co.uk>,
        Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
        "H. Peter Anvin" <hpa@zytor.com>, "Zhang, Rui" <rui.zhang@intel.com>
Subject: RE: [PATCH][RFC v3] ACPI / PM: Fix poweroff issue on HW-full
 platforms without _S5
Thread-Topic: [PATCH][RFC v3] ACPI / PM: Fix poweroff issue on HW-full
 platforms without _S5
Thread-Index: AQHReBtTuYTrZFDLZkGy2iiQCJLNIJ9NcY+AgACwtaA=
Date: Mon, 7 Mar 2016 15:53:13 +0000
Message-ID: <36DF59CE26D8EE47B0655C516E9CE640286D329F@shsmsx102.ccr.corp.intel.com>
References: <1457319045-25434-1-git-send-email-yu.c.chen@intel.com>
 <CAJZ5v0iWjW_XJEsVBM1yyimxUQMDaWapQ_OrN45TeFXFySd0rw@mail.gmail.com>
In-Reply-To: <CAJZ5v0iWjW_XJEsVBM1yyimxUQMDaWapQ_OrN45TeFXFySd0rw@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMjgzMWEzMWYtMDEwMC00ZjMxLWI2MzgtMTA2YTVhOWRkNGNjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IjZIZzV4RDZvb2FVZmdXalo1SmpaZnRMNGdvT0VzeDBFZ2FxcUxpRld0TzQ9In0=
x-ctpclassification: CTP_IC
x-originating-ip: [10.239.127.40]
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u27Frb2p014318
Content-Length: 887
Lines: 27

Hi Rafael,
(resend for broken content)

> -----Original Message-----
> From: rjwysocki@gmail.com [mailto:rjwysocki@gmail.com] On Behalf Of
> Rafael J. Wysocki
> Sent: Monday, March 07, 2016 9:19 PM
> To: Chen, Yu C
> Cc: ACPI Devel Maling List; x86@kernel.org; linux-efi@vger.kernel.org; Linux
> Kernel Mailing List; linux-pm@vger.kernel.org; Rafael J. Wysocki; Len Brown;
> Matt Fleming; Thomas Gleixner; Ingo Molnar; H. Peter Anvin; Zhang, Rui
> Subject: Re: [PATCH][RFC v3] ACPI / PM: Fix poweroff issue on HW-full
> platforms without _S5
> 
[cut]
> >  bool efi_poweroff_required(void)
> >  {
> > -       return !!acpi_gbl_reduced_hardware;
> > +       return acpi_gbl_reduced_hardware || (acpi_no_s5 &&
> > + !pm_power_off);
> 
> What if CONFIG_ACPI is not set here?
If CONFIG_ACPI is not set, this file would not 
be compiled, because CONFIG_EFI depends on CONFIG_ACPI.

thanks,
yu